Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit ed29460

Browse files
authored
Merge pull request #4758 from magento/small_changes
Small changes
2 parents a649ac3 + a241494 commit ed29460

File tree

5 files changed

+18
-11
lines changed

5 files changed

+18
-11
lines changed

_config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ defaults:
7474
path: mftf/docs
7575
values:
7676
group: mftf
77-
github_files: https://github.com/magento/magento2-functional-testing-framework/blob/develop/
77+
github_files: https://github.com/magento/magento2-functional-testing-framework/blob/master/
7878
github_repo: https://github.com/magento/magento2-functional-testing-framework/
7979
functional_areas:
8080
- Test

guides/v2.1/cloud/cdn/fastly-vcl-whitelist.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ Add the custom VCL snippet to your Fastly service configuration from the Magento
111111
```
112112
113113
1. Click **Create** to generate the VCL snippet file with the name pattern `type_priority_name.vcl`, for example `recv_5_allowlist.vcl`
114-
115-
![Create VCL Snippet]
116114
117115
1. After the page reloads, click **Upload VCL to Fastly** in the *Fastly Configuration* section to add the file to the Fastly service configuration.
118116

guides/v2.1/frontend-dev-guide/translations/theme_dictionary.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,15 @@ The locale dictionary would use the default values (keys) in the left column fol
6161
"Card Verification Number", <translation>
6262
```
6363

64+
## Element translations per module
65+
66+
You can translate the same element in different ways for different modules:
67+
68+
```text
69+
"Add to Cart", "Add to Cart", module, Magento_Review
70+
"Add to Cart", "Add to Shopping Cart", module, Magento_Catalog
71+
```
72+
6473
## Additional information
6574

6675
- [Translations overview]

guides/v2.1/javascript-dev-guide/javascript/js_init.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ To call a JS component on an HTML element without direct access to the element o
6767
<script type="text/x-magento-init">
6868
{
6969
// components initialized on the element defined by selector
70-
"<element_selector>": {
71-
"<js_component1>": ...,
72-
"<js_component2>": ...
70+
"<element_selector>": {
71+
"<js_component1>": ...,
72+
"<js_component2>": ...
7373
},
7474
// components initialized without binding to an element
7575
"*": {
@@ -139,8 +139,8 @@ $(function () { // to ensure that code evaluates on page load
139139
$('[data-role=example]') // we expect that page contains markup <tag data-role="example">..</tag>
140140
.accordion({ // now we can use "accordion" as jQuery plugin
141141
header: '[data-role=header]',
142-
content: '[data-role=content]',
143-
trigger: '[data-role=trigger]',
142+
content: '[data-role=content]',
143+
trigger: '[data-role=trigger]',
144144
ajaxUrlElement: 'a'
145145
});
146146
});

guides/v2.1/javascript-dev-guide/widgets/widget_prompt.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ The prompt widget can be initialized with or without binding to a certain elemen
2222

2323
```javascript
2424
$('#prompt_init').prompt({
25-
title: 'Prompt title',
25+
title: $.mage.__('Prompt title'),
2626
actions: {
2727
confirm: function(){}, //callback on 'Ok' button click
2828
cancel: function(){}, //callback on 'Cancel' button click
@@ -39,8 +39,8 @@ require([
3939
], function(prompt) { // Variable that represents the `prompt` function
4040

4141
prompt({
42-
title: 'Some title',
43-
content: 'Some content',
42+
title: $.mage.__('Some title'),
43+
content: $.mage.__('Some content'),
4444
actions: {
4545
confirm: function(){},
4646
cancel: function(){},

0 commit comments

Comments
 (0)