Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story #26] User sets the image name #328

Closed
tkacheva opened this issue Aug 8, 2019 · 4 comments
Closed

[Story #26] User sets the image name #328

tkacheva opened this issue Aug 8, 2019 · 4 comments

Comments

@tkacheva
Copy link

tkacheva commented Aug 8, 2019

Story

As a Merchant I want to set the image file name so that I can better optimize it for SEO purposes

Business Value

update image file via UI

Preconditions

  • Admin User is logged into Admin Panel
  • Admin Users saves preview image or license it

Acceptance Criteria

  • User sees the option to set a file url name for the image they are saving
  • User sees suggested url that is generated out of file title. Encoding is used when necessary to make URL safe. Length is limited to 128
  • User can update the URL. If user updates the URL, URL Safe characters supported.
  • User saves the changes
  • User sees image saved with the URL confirmed. If the URL provided already exists, error message displayed
@sivaschenko
Copy link
Member

Still requires restyling and adding to licensing flow

@tkacheva
Copy link
Author

tkacheva commented Nov 1, 2019

@sivaschenko I keep seeing the issue that image with special characters in the name are not correctly rendered in Magento
Screen Shot 2019-11-01 at 11 59 32 AM

@sivaschenko
Copy link
Member

sivaschenko commented Nov 22, 2019

Restrict copy-paste for special characters and add validation on "Confirm". @belbiy please provide a message

@sivaschenko
Copy link
Member

Saving image with special characters is prevented:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants