Skip to content

Introduce a new layer 0 for transform characteristics#12055

Open
DominionSpy wants to merge 1 commit into
magefree:masterfrom
DominionSpy:transform-characteristics-layer
Open

Introduce a new layer 0 for transform characteristics#12055
DominionSpy wants to merge 1 commit into
magefree:masterfrom
DominionSpy:transform-characteristics-layer

Conversation

@DominionSpy
Copy link
Copy Markdown
Contributor

Fixes #11683

As discussed in the issue above and #11677, this introduces a new layer 0 for transform characteristics. This is done so that the effect of a transformed permanent can be applied before any effects in layer 1 (copy effects).

@github-actions github-actions Bot added the engine label Apr 3, 2024
@DominionSpy
Copy link
Copy Markdown
Contributor Author

I'm not sure how to go about writing tests for this without a card example. There are no existing implemented cards that are affected by this issue.

@jeffwadsworth
Copy link
Copy Markdown
Contributor

If you have the Paleontologist's Pick-Axe // Dinosaur Headdress implemented using this code, I assume you were able to test it. Is that correct? That card looked like it had some requested changes to be made, etc.

Copy link
Copy Markdown
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test framework allows to construct any cards with any abilities (activated, static, etc). If you don't have real card or it hard to use for some use cases then use addCustomCardWithAbility.

Such global game engine changes must be merged with some unit tests (test must works in new version and fails in old version).

P.S. It's not about changes -- old PR #11677 has same problems with lack of tests and proofs.

@DominionSpy
Copy link
Copy Markdown
Contributor Author

Test framework allows to construct any cards with any abilities (activated, static, etc). If you don't have real card or it hard to use for some use cases then use addCustomCardWithAbility.

I've had a look into this, but I can't see how I can set up a DFC with transform.
To test this, I at least need to have a transformed card with a copy effect on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A transformed card with a static copy ability does not work

3 participants