Introduce a new layer 0 for transform characteristics#12055
Conversation
|
I'm not sure how to go about writing tests for this without a card example. There are no existing implemented cards that are affected by this issue. |
|
If you have the Paleontologist's Pick-Axe // Dinosaur Headdress implemented using this code, I assume you were able to test it. Is that correct? That card looked like it had some requested changes to be made, etc. |
JayDi85
left a comment
There was a problem hiding this comment.
Test framework allows to construct any cards with any abilities (activated, static, etc). If you don't have real card or it hard to use for some use cases then use addCustomCardWithAbility.
Such global game engine changes must be merged with some unit tests (test must works in new version and fails in old version).
P.S. It's not about changes -- old PR #11677 has same problems with lack of tests and proofs.
I've had a look into this, but I can't see how I can set up a DFC with transform. |
Fixes #11683
As discussed in the issue above and #11677, this introduces a new layer 0 for transform characteristics. This is done so that the effect of a transformed permanent can be applied before any effects in layer 1 (copy effects).