Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: wrap log.Println in cmd with verbose check #399

Merged
merged 2 commits into from
Jan 16, 2022
Merged

chore: wrap log.Println in cmd with verbose check #399

merged 2 commits into from
Jan 16, 2022

Conversation

viktorvoltaire
Copy link
Contributor

@viktorvoltaire viktorvoltaire commented Dec 23, 2021 •
edited
Loading

This was introduced in #306 it feels like it was left there by mistake. Its causing a lot of unwanted log prints

Edit: This is triggered from doing sh.Output/Run etc... in a global variable.

@viktorvoltaire
Copy link
Contributor Author

@mirogta @natefinch

@viktorvoltaire viktorvoltaire mentioned this pull request Dec 23, 2021
Merged
@mirogta
Copy link
Member

mirogta commented Dec 23, 2021 •
edited
Loading

Looking at #306, it's a 2yr old issue.

So I'm actually looking at the main branch before that was merged and it looks like it did have the log there.

I understand that some people might not like this extra logging, but it doesn't look like it was introduced in #306 and removing it might be seen as a breaking change. We try to prevent any breaking changes.

@natefinch could we wrap this line with a Verbose check, as an improvement/compromise?

@viktorvoltaire
Copy link
Contributor Author

@mirogta you are correct, I was to hot on the git blame. Ive been debugging this a bit with @natefinch and found out that the unwanted behavior comes from a global variable

@viktorvoltaire
Copy link
Contributor Author

viktorvoltaire commented Dec 23, 2021 •
edited
Loading

@mirogta @natefinch I tested this locally and with the conditional I dont get any more output from doing exec in globals. But with -v I do :)

@viktorvoltaire viktorvoltaire changed the title chore: remove log.Println from cmd chore: wrap log.Println in cmd with verbose check Dec 23, 2021
natefinch
natefinch approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good, clean fix. Thanks!

@natefinch natefinch merged commit 3a11bce into magefile:master Jan 16, 2022
scottames referenced this pull request in scottames/cmder Apr 22, 2023
@renovate
chore(deps): update ⇡ golang module github.com/magefile/mage to v1.14…
de0533f 
….0 (#6)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/magefile/mage](https://togithub.com/magefile/mage) |
require | minor | `v1.11.0` -> `v1.14.0` |

---

### Release Notes

<details>
<summary>magefile/mage</summary>

###
[`v1.14.0`](https://togithub.com/magefile/mage/releases/tag/v1.14.0): -
Faster Than Ever

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.13.0...v1.14.0)

#### What's Changed

- give props to netlify on the main page by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[https://github.com/magefile/mage/pull/410](https://togithub.com/magefile/mage/pull/410)
- Update site to build with newer hugo by
[@&#8203;perrito666](https://togithub.com/perrito666) in
[https://github.com/magefile/mage/pull/411](https://togithub.com/magefile/mage/pull/411)
- bring docs for use of directives up to date by
[@&#8203;efd6](https://togithub.com/efd6) in
[https://github.com/magefile/mage/pull/407](https://togithub.com/magefile/mage/pull/407)
- add blog post about v1.13 by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[https://github.com/magefile/mage/pull/412](https://togithub.com/magefile/mage/pull/412)
- fix author links by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[https://github.com/magefile/mage/pull/413](https://togithub.com/magefile/mage/pull/413)
- Add variadic support to mg.F by
[@&#8203;perj](https://togithub.com/perj) in
[https://github.com/magefile/mage/pull/402](https://togithub.com/magefile/mage/pull/402)
- feat: rename templated imports to avoid collisions by
[@&#8203;ladydascalie](https://togithub.com/ladydascalie) in
[https://github.com/magefile/mage/pull/421](https://togithub.com/magefile/mage/pull/421)
- Website: fixing typos by
[@&#8203;deining](https://togithub.com/deining) in
[https://github.com/magefile/mage/pull/429](https://togithub.com/magefile/mage/pull/429)
- refactor(listGoFiles): remove go list dependency by
[@&#8203;jaredallard](https://togithub.com/jaredallard) in
[https://github.com/magefile/mage/pull/440](https://togithub.com/magefile/mage/pull/440)
- doc: add MacPorts install info by
[@&#8203;herbygillot](https://togithub.com/herbygillot) in
[https://github.com/magefile/mage/pull/419](https://togithub.com/magefile/mage/pull/419)

#### New Contributors

- [@&#8203;efd6](https://togithub.com/efd6) made their first
contribution in
[https://github.com/magefile/mage/pull/407](https://togithub.com/magefile/mage/pull/407)
- [@&#8203;perj](https://togithub.com/perj) made their first
contribution in
[https://github.com/magefile/mage/pull/402](https://togithub.com/magefile/mage/pull/402)
- [@&#8203;ladydascalie](https://togithub.com/ladydascalie) made their
first contribution in
[https://github.com/magefile/mage/pull/421](https://togithub.com/magefile/mage/pull/421)
- [@&#8203;deining](https://togithub.com/deining) made their first
contribution in
[https://github.com/magefile/mage/pull/429](https://togithub.com/magefile/mage/pull/429)
- [@&#8203;jaredallard](https://togithub.com/jaredallard) made their
first contribution in
[https://github.com/magefile/mage/pull/440](https://togithub.com/magefile/mage/pull/440)
- [@&#8203;herbygillot](https://togithub.com/herbygillot) made their
first contribution in
[https://github.com/magefile/mage/pull/419](https://togithub.com/magefile/mage/pull/419)

**Full Changelog**:
magefile/mage@v1.13.0...v1.14.0

###
[`v1.13.0`](https://togithub.com/magefile/mage/releases/tag/v1.13.0): -
Magefiles Directory and more!

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.12.1...v1.13.0)

#### What's Changed

- feat: allow mage:import alias to be defined for multiple imports by
[@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) in
[https://github.com/magefile/mage/pull/398](https://togithub.com/magefile/mage/pull/398)
- chore: wrap log.Println in cmd with verbose check by
[@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) in
[https://github.com/magefile/mage/pull/399](https://togithub.com/magefile/mage/pull/399)
- Detect deps that have already been invoked by
[@&#8203;carolynvs](https://togithub.com/carolynvs) in
[https://github.com/magefile/mage/pull/346](https://togithub.com/magefile/mage/pull/346)
- Replace godoc.org URLs by
[@&#8203;JamieEdge](https://togithub.com/JamieEdge) in
[https://github.com/magefile/mage/pull/342](https://togithub.com/magefile/mage/pull/342)
- Add magefiles directory support by
[@&#8203;perrito666](https://togithub.com/perrito666) in
[https://github.com/magefile/mage/pull/405](https://togithub.com/magefile/mage/pull/405)

#### New Contributors

- [@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) made
their first contribution in
[https://github.com/magefile/mage/pull/398](https://togithub.com/magefile/mage/pull/398)
- [@&#8203;carolynvs](https://togithub.com/carolynvs) made their first
contribution in
[https://github.com/magefile/mage/pull/346](https://togithub.com/magefile/mage/pull/346)
- [@&#8203;JamieEdge](https://togithub.com/JamieEdge) made their first
contribution in
[https://github.com/magefile/mage/pull/342](https://togithub.com/magefile/mage/pull/342)
- [@&#8203;perrito666](https://togithub.com/perrito666) made their first
contribution in
[https://github.com/magefile/mage/pull/405](https://togithub.com/magefile/mage/pull/405)

**Full Changelog**:
magefile/mage@v1.12.1...v1.13.0

###
[`v1.12.1`](https://togithub.com/magefile/mage/releases/tag/v1.12.1): -
Second Verse, Same as the First

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.12.0...v1.12.1)

This is a copy of v1.12.0 ... nothing has changed. However, there was an
initial v1.12.0 that was created accidentally, and then deleted, and
it's causing some go proxies to complain. So hopefully this will fix
that.

#### Changelog

- [`2f1ec40`](https://togithub.com/magefile/mage/commit/2f1ec40) ci:
migrate from travis to github action
([#&#8203;391](https://togithub.com/magefile/mage/issues/391))
- [`fe9f942`](https://togithub.com/magefile/mage/commit/fe9f942)
evidently goreleaseer has changed in the last 4 years :)
([#&#8203;394](https://togithub.com/magefile/mage/issues/394))
- [`fd5011e`](https://togithub.com/magefile/mage/commit/fd5011e) Fix the
rollback mechanism for tags during a release
([#&#8203;392](https://togithub.com/magefile/mage/issues/392))
- [`404c119`](https://togithub.com/magefile/mage/commit/404c119)
sh.run(): quoted strings before join
([#&#8203;306](https://togithub.com/magefile/mage/issues/306))
- [`0c5affe`](https://togithub.com/magefile/mage/commit/0c5affe) Add
asdf installation instructions to docs
([#&#8203;383](https://togithub.com/magefile/mage/issues/383))
- [`e84bbc1`](https://togithub.com/magefile/mage/commit/e84bbc1)
[#&#8203;288](https://togithub.com/magefile/mage/issues/288) add brew
and scoop install to docs
([#&#8203;376](https://togithub.com/magefile/mage/issues/376))
- [`80953f7`](https://togithub.com/magefile/mage/commit/80953f7)
[#&#8203;378](https://togithub.com/magefile/mage/issues/378) bump
travisci go16
([#&#8203;379](https://togithub.com/magefile/mage/issues/379))
- [`dd94424`](https://togithub.com/magefile/mage/commit/dd94424) Create
issue templates
([#&#8203;374](https://togithub.com/magefile/mage/issues/374))
- [`d9e2e41`](https://togithub.com/magefile/mage/commit/d9e2e41) fix:
deterministic compiled mainfile
([#&#8203;348](https://togithub.com/magefile/mage/issues/348))
- [`4cf3cfc`](https://togithub.com/magefile/mage/commit/4cf3cfc) make -h
work with imported targets
([#&#8203;335](https://togithub.com/magefile/mage/issues/335))
- [`de7ca6c`](https://togithub.com/magefile/mage/commit/de7ca6c) fix
test for go 1.16
([#&#8203;330](https://togithub.com/magefile/mage/issues/330))

###
[`v1.12.0`](https://togithub.com/magefile/mage/releases/tag/v1.12.0): -
Small Fixes

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.11.0...v1.12.0)

This is our first release in a while, and nothing major is added, but
some small fixes have gone out, like making the mainfile deterministic
and making sure we can use -h with imported targets.

#### Changelog

- [`2f1ec40`](https://togithub.com/magefile/mage/commit/2f1ec40) ci:
migrate from travis to github action
([#&#8203;391](https://togithub.com/magefile/mage/issues/391))
- [`fe9f942`](https://togithub.com/magefile/mage/commit/fe9f942)
evidently goreleaseer has changed in the last 4 years :)
([#&#8203;394](https://togithub.com/magefile/mage/issues/394))
- [`fd5011e`](https://togithub.com/magefile/mage/commit/fd5011e) Fix the
rollback mechanism for tags during a release
([#&#8203;392](https://togithub.com/magefile/mage/issues/392))
- [`404c119`](https://togithub.com/magefile/mage/commit/404c119)
sh.run(): quoted strings before join
([#&#8203;306](https://togithub.com/magefile/mage/issues/306))
- [`0c5affe`](https://togithub.com/magefile/mage/commit/0c5affe) Add
asdf installation instructions to docs
([#&#8203;383](https://togithub.com/magefile/mage/issues/383))
- [`e84bbc1`](https://togithub.com/magefile/mage/commit/e84bbc1)
[#&#8203;288](https://togithub.com/magefile/mage/issues/288) add brew
and scoop install to docs
([#&#8203;376](https://togithub.com/magefile/mage/issues/376))
- [`80953f7`](https://togithub.com/magefile/mage/commit/80953f7)
[#&#8203;378](https://togithub.com/magefile/mage/issues/378) bump
travisci go16
([#&#8203;379](https://togithub.com/magefile/mage/issues/379))
- [`dd94424`](https://togithub.com/magefile/mage/commit/dd94424) Create
issue templates
([#&#8203;374](https://togithub.com/magefile/mage/issues/374))
- [`d9e2e41`](https://togithub.com/magefile/mage/commit/d9e2e41) fix:
deterministic compiled mainfile
([#&#8203;348](https://togithub.com/magefile/mage/issues/348))
- [`4cf3cfc`](https://togithub.com/magefile/mage/commit/4cf3cfc) make -h
work with imported targets
([#&#8203;335](https://togithub.com/magefile/mage/issues/335))
- [`de7ca6c`](https://togithub.com/magefile/mage/commit/de7ca6c) fix
test for go 1.16
([#&#8203;330](https://togithub.com/magefile/mage/issues/330))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/cmder).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefinch natefinch natefinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorvoltaire @mirogta @natefinch