Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update home page with a better example #293

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Conversation

guumaster
Copy link
Contributor

It was confusing for me to get started with the current example, I don't have dep installed and I think the example with go mod download may be a better example.

Also change the order of installation methods, recommending go modules instead of $GOPATH.

Also change the order of installation methods, recommending `go modules` instead of $GOPATH.
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@guumaster
Copy link
Contributor Author

@natefinch do you need something else on this branch before merging it?

@natefinch
Copy link
Member

Sorry, thought I already merged this. Will do so now.

@natefinch natefinch merged commit 310e198 into magefile:master Apr 16, 2020
@guumaster guumaster deleted the patch-1 branch April 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants