Skip to content

Conversation

@Vinai
Copy link
Contributor

@Vinai Vinai commented Oct 5, 2023

The decision has been made to disable the workflow until we have the resources to fork and fix the project, and decide to do so.

Description (*)

The workflow currently seems to be broken.
Example from github.com/mage-os/mageos-magento2/actions/runs/6424122506/job/17444076317?pr=22:

Run magento-semver/bin/svc compare base-branch this-change
  magento-semver/bin/svc compare base-branch this-change
  shell: /usr/bin/bash -e {0}
PHP Fatal error:  Uncaught Error: Object of class Less_Tree_Quoted could not be converted to string in /home/runner/work/mageos-magento[2](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:2)/mageos-magento2/magento-semver/src/Analyzer/Less/Analyzer.php:1[3](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:3)1
Stack trace:
#0 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/Analyzer/Less/Analyzer.php(63): Magento\SemanticVersionChecker\Analyzer\Less\Analyzer->getNodes()
#1 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/Analyzer/Analyzer.php([4](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:5)[5](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:6)): Magento\SemanticVersionChecker\Analyzer\Less\Analyzer->analyze()
#2 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/ReportBuilder.php(221): Magento\SemanticVersionChecker\Analyzer\Analyzer->analyze()
#3 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/ReportBuilder.php(14[6](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:7)): Magento\SemanticVersionChecker\ReportBuilder->buildReport()
#4 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/ReportBuilder.php(115): Magento\SemanticVersionChecker\ReportBuilder->makeVersionReport()
#5 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/SemanticVersionChecker.php(60): Magento\SemanticVersionChecker\ReportBuilder->makeCompleteVersionReport()
#6 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/SemanticVersionChecker.php(86): Magento\SemanticVersionChecker\SemanticVersionChecker->loadVersionReport()
#[7](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:8) /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/Console/Command/CompareSourceCommand.php(149): Magento\SemanticVersionChecker\SemanticVersionChecker->getVersionIncrease()
#[8](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:9) /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/vendor/symfony/console/Command/Command.php(2[9](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:10)8): Magento\SemanticVersionChecker\Console\Command\CompareSourceCommand->execute()
#9 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/vendor/symfony/console/Application.php([10](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:11)40): Symfony\Component\Console\Command\Command->run()
#10 /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#[11](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:12) /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun()
#[12](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:13) /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/bin/svc(30): Symfony\Component\Console\Application->run()
#[13](https://github.com/mage-os/mageos-magento2/actions/runs/6359087761/job/17443280849?pr=36#step:10:14) {main}
  thrown in /home/runner/work/mageos-magento2/mageos-magento2/magento-semver/src/Analyzer/Less/Analyzer.php on line 131

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

The workflow currently seems to be broken.
The decision has been made to disable the workflow ntil we have
the resources to fork and fix the project, and decide to do so.
@Vinai Vinai requested a review from a team as a code owner October 5, 2023 21:12
@mage-os-ci mage-os-ci merged commit db9ec29 into mage-os:2.4-develop Oct 5, 2023
mage-os-ci pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants