Help Wanted: Symfony Usage - required to Close Streams?

[th-lange]

ZipStream has some really awesome documentation.
I use the Symfony Package and everything worked as expected.

But reading through this documentation:

• https://maennchen.dev/ZipStream-PHP/guide/Symfony.html#usage-with-symfony

Is it necessary, to close the streams?
Where would this ideally go?

I was considering something like:

    public function downloadDocuments(DownloadDocumentsDto $dto): Response
    {

       // ....

      // try
        $response = new StreamedResponse(function() use($dto) {
            $zip = new ZipStream(
                sendHttpHeaders: true,
                outputName: sprintf("files.%s.zip", time()),
            );

            foreach ($dto->getDocuments() as $file) {
                $zip->addFileFromStream($file->getDocumentName(), $file->getStream());
            }

            $zip->finish();
      // finally -> close all streams
        });

        return $response;
    }

[maennchen]

You should close the streams directly after each addFileFromStream call. After the call is finished, the stream will no longer be referenced / needed.

[th-lange]

Thanks for the quick reply!