Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: transactions hash and l1_data_gas_price mismatch with mainnet #145

Closed
Ophiase opened this issue Jun 7, 2024 · 2 comments
Closed

bug: transactions hash and l1_data_gas_price mismatch with mainnet #145

Ophiase opened this issue Jun 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Ophiase
Copy link
Contributor

Ophiase commented Jun 7, 2024

Bug Report

The bug on transactions hash was introduced with #134
The bug with l1_data_gas_price mismatch was at least already there in #123

https://rpc-request-builder.voyager.online/

Using starknet_getBlockWithTxHashes, compare on block number 1 the json response over http://localhost:9944 and Mainnet (by clicking on Use default RPC URL)

The response Json from localhost should match with Mainnet.
Its partially working in #133 but not in #134

@Ophiase Ophiase added the bug Something isn't working label Jun 7, 2024
@Ophiase
Copy link
Contributor Author

Ophiase commented Jun 8, 2024

After further analysis, the problem doesn't seem to come from transactions.rs but lib.rs.
Remark: in #133 the block 0 can be requested, not in #134 (error generated from lib.rs "Block not found")

@Ophiase
Copy link
Contributor Author

Ophiase commented Jun 11, 2024

Fixed in #143

@Ophiase Ophiase closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant