New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Representations for objects #11

Open

2 tasks

AKuederle opened this issue Dec 13, 2021 · 0 comments

Labels

good first issue help wanted

Member

AKuederle commented Dec 13, 2021 •

edited

Loading

#13 implements a basic version of a representation.

However, it has some remaining issues:

Long representations are alls hown in the same line (maybe use this: https://github.com/scikit-learn/scikit-learn/blob/056f993b411c1fa5cf6a2ced8e51de03617b25b4/sklearn/base.py#L104)
objects with unuasual representaitons (e.g. pd.DataFrames) can mess up the formatting, when included as a paramter)

Some further notes:

sklearn does something very elegant and does not include parameters in the repr that are still at their default value.
Dataset already has a repr that does not include the parameters. It might be nice to include the custom user parameters in that representation as well.

AKuederle added good first issue help wanted labels

AKuederle mentioned this issue

basic implementation of __repr__ #13

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment