Skip to content

Commit c40d9b4

Browse files
committed
Fix qlstephen project warnings
Part of this was originally part of #1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From #1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - The post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings.
1 parent 92082eb commit c40d9b4

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/MacVim/qlstephen/QuickLookStephen.xcodeproj/project.pbxproj

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
0107ABFC15C76F2900C65F1A /* QLSFileAttributes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QLSFileAttributes.h; sourceTree = "<group>"; };
2525
0107ABFD15C76F2900C65F1A /* QLSFileAttributes.m */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 2; lastKnownFileType = sourcecode.c.objc; path = QLSFileAttributes.m; sourceTree = "<group>"; tabWidth = 2; usesTabs = 0; };
2626
0149EB3D15F2E9A3003AB298 /* libicucore.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libicucore.dylib; path = usr/lib/libicucore.dylib; sourceTree = SDKROOT; };
27-
089C167EFE841241C02AAC07 /* English */ = {isa = PBXFileReference; fileEncoding = 10; lastKnownFileType = text.plist.strings; name = English; path = English.lproj/InfoPlist.strings; sourceTree = "<group>"; };
2827
08FB77B6FE84183AC02AAC07 /* main.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = main.c; sourceTree = "<group>"; };
2928
0AA1909FFE8422F4C02AAC07 /* CoreFoundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreFoundation.framework; path = /System/Library/Frameworks/CoreFoundation.framework; sourceTree = "<absolute>"; };
3029
2C05A19B06CAA52B00D84F6F /* GeneratePreviewForURL.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GeneratePreviewForURL.m; sourceTree = "<group>"; usesTabs = 0; };
3130
61E3BCFA0870B4F2002186A0 /* GenerateThumbnailForURL.m */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.objc; path = GenerateThumbnailForURL.m; sourceTree = "<group>"; };
3231
8D576316048677EA00EA77CD /* QLStephen.qlgenerator */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = QLStephen.qlgenerator; sourceTree = BUILT_PRODUCTS_DIR; };
3332
8D576317048677EA00EA77CD /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist; path = Info.plist; sourceTree = "<group>"; };
33+
95241CDF2573D584001E3711 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
3434
AE02F6EA0EDDFA6400CBA17D /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = "<absolute>"; };
3535
C86B05260671AA6E00DD9006 /* CoreServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreServices.framework; path = /System/Library/Frameworks/CoreServices.framework; sourceTree = "<absolute>"; };
3636
F28CFBFC0A3EC0AF000ABFF5 /* ApplicationServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ApplicationServices.framework; path = /System/Library/Frameworks/ApplicationServices.framework; sourceTree = "<absolute>"; };
@@ -138,10 +138,11 @@
138138
};
139139
buildConfigurationList = 2CA326220896AD4900168862 /* Build configuration list for PBXProject "QuickLookStephen" */;
140140
compatibilityVersion = "Xcode 3.2";
141-
developmentRegion = English;
141+
developmentRegion = en;
142142
hasScannedForEncodings = 1;
143143
knownRegions = (
144144
en,
145+
Base,
145146
);
146147
mainGroup = 089C166AFE841209C02AAC07 /* QuickLookStephen */;
147148
projectDirPath = "";
@@ -166,6 +167,7 @@
166167
/* Begin PBXShellScriptBuildPhase section */
167168
698210201CC62DD000504BBF /* ShellScript */ = {
168169
isa = PBXShellScriptBuildPhase;
170+
alwaysOutOfDate = 1;
169171
buildActionMask = 2147483647;
170172
files = (
171173
);
@@ -197,7 +199,7 @@
197199
8D5B49A704867FD3000E48DA /* InfoPlist.strings */ = {
198200
isa = PBXVariantGroup;
199201
children = (
200-
089C167EFE841241C02AAC07 /* English */,
202+
95241CDF2573D584001E3711 /* en */,
201203
);
202204
name = InfoPlist.strings;
203205
sourceTree = "<group>";
@@ -240,12 +242,13 @@
240242
2CA326230896AD4900168862 /* Debug */ = {
241243
isa = XCBuildConfiguration;
242244
buildSettings = {
245+
ALWAYS_SEARCH_USER_PATHS = NO;
243246
ENABLE_TESTABILITY = YES;
244247
GCC_C_LANGUAGE_STANDARD = c99;
245248
GCC_PREPROCESSOR_DEFINITIONS = "RKL_PREPEND_TO_METHODS=rkl_";
249+
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
246250
GCC_WARN_ABOUT_RETURN_TYPE = YES;
247251
GCC_WARN_UNUSED_VARIABLE = YES;
248-
MACOSX_DEPLOYMENT_TARGET = 10.8;
249252
ONLY_ACTIVE_ARCH = YES;
250253
SDKROOT = macosx;
251254
WARNING_CFLAGS = (
@@ -259,11 +262,12 @@
259262
2CA326240896AD4900168862 /* Release */ = {
260263
isa = XCBuildConfiguration;
261264
buildSettings = {
265+
ALWAYS_SEARCH_USER_PATHS = NO;
262266
GCC_C_LANGUAGE_STANDARD = c99;
263267
GCC_PREPROCESSOR_DEFINITIONS = "RKL_PREPEND_TO_METHODS=rkl_";
268+
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
264269
GCC_WARN_ABOUT_RETURN_TYPE = YES;
265270
GCC_WARN_UNUSED_VARIABLE = YES;
266-
MACOSX_DEPLOYMENT_TARGET = 10.8;
267271
SDKROOT = macosx;
268272
WARNING_CFLAGS = (
269273
"-Wextra",

0 commit comments

Comments
 (0)