Skip to content

Commit b87e695

Browse files
committed
Fix set fullscreen not working after upstream Vim merge
The recent upstream Vim merge (v9.0.1365) contained a lot of refactoring in the option setting code. Handling option setting was now done via a standardized callback, with a struct `optset_T`. In resolving the upstream merge conflicts, `did_set_fullscreen` was erroneously using the wrong value from the union (should be using boolean instead of number) which leads to it occasionally giving unpredictable results. Fix the bug. Note that the bug seems a little unpredictable since it depends on compiler specifics. The only way it was known to trigger was by `set diff` followed by `set fullscreen`. Fix #1378
1 parent df0ffe9 commit b87e695

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/option.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3505,7 +3505,7 @@ did_set_textmode(optset_T *args)
35053505
char *
35063506
did_set_fullscreen(optset_T *args)
35073507
{
3508-
long old_value = args->os_oldval.number;
3508+
long old_value = args->os_oldval.boolean;
35093509
if (p_fullscreen && !old_value)
35103510
{
35113511
guicolor_T fg, bg;

0 commit comments

Comments
 (0)