PDFBOX-4892: simplify code, as suggested by valerybokov

THausherr · THausherr · commit cfc4a4f92d4b · 2021-07-18T10:28:44.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1891646 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/preflight/src/main/java/org/apache/pdfbox/preflight/metadata/SynchronizedMetaDataValidation.java b/preflight/src/main/java/org/apache/pdfbox/preflight/metadata/SynchronizedMetaDataValidation.java
@@ -525,9 +525,8 @@ protected ValidationException schemaAccessException(String target, Throwable cau
      */
     protected ValidationError unsynchronizedMetaDataError(String target)
     {
-        StringBuilder sb = new StringBuilder(80);
-        sb.append(target).append(" present in the document catalog dictionary doesn't match with XMP information");
-        return new ValidationError(PreflightConstants.ERROR_METADATA_MISMATCH, sb.toString());
+        return new ValidationError(PreflightConstants.ERROR_METADATA_MISMATCH, target +
+                " present in the document catalog dictionary doesn't match with XMP information");
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -525,9 +525,8 @@ protected ValidationException schemaAccessException(String target, Throwable cau`
`525`	`525`	`*/`
`526`	`526`	`protected ValidationError unsynchronizedMetaDataError(String target)`
`527`	`527`	`{`
`528`		`- StringBuilder sb = new StringBuilder(80);`
`529`		`- sb.append(target).append(" present in the document catalog dictionary doesn't match with XMP information");`
`530`		`- return new ValidationError(PreflightConstants.ERROR_METADATA_MISMATCH, sb.toString());`
	`528`	`+ return new ValidationError(PreflightConstants.ERROR_METADATA_MISMATCH, target +`
	`529`	`+ " present in the document catalog dictionary doesn't match with XMP information");`
`531`	`530`	`}`
`532`	`531`
`533`	`532`	`/**`