PDFBOX-4892: optimize code, as suggested by valerybokov

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1891448 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java

@@ -251,10 +251,10 @@ protected void processICCBasedColorSpace(PDColorSpace colorSpace)
                 // PDFBOX-2819: load ICC profile as a stream, not as a byte array because of java error
                 iccp = ICC_Profile.getInstance(is);
             }
-            PDColorSpace altpdcs = iccBased.getAlternateColorSpace();
-            if (altpdcs != null)
+            PDColorSpace alternateColorSpace = iccBased.getAlternateColorSpace();
+            if (alternateColorSpace != null)
             {
-                ColorSpaces altCsId = ColorSpaces.valueOf(altpdcs.getName());
+                ColorSpaces altCsId = ColorSpaces.valueOf(alternateColorSpace.getName());
                 if (altCsId == ColorSpaces.Pattern)
                 {
                     context.addValidationError(new ValidationError(
@@ -280,7 +280,7 @@ protected void processICCBasedColorSpace(PDColorSpace colorSpace)
                 {
                     return;
                 }
-                validateICCProfileAlternateEntry(iccBased);
+                validateICCProfileAlternateEntry(iccBased, alternateColorSpace);
             }
         }
         catch (IllegalArgumentException | ArrayIndexOutOfBoundsException e)
@@ -543,16 +543,16 @@ private boolean validateICCProfileNEntry(COSStream stream, ICC_Profile iccp)
         return true;
     }
 
-    private void validateICCProfileAlternateEntry(PDICCBased iccBased) throws IOException
+    private void validateICCProfileAlternateEntry(
+            PDICCBased iccBased, PDColorSpace alternateColorSpace) throws IOException
     {
-        PDColorSpace altCS = iccBased.getAlternateColorSpace();
-        if (altCS != null && altCS.getNumberOfComponents() != iccBased.getNumberOfComponents())
+        if (alternateColorSpace.getNumberOfComponents() != iccBased.getNumberOfComponents())
         {
             // https://github.com/veraPDF/veraPDF-library/issues/773
             context.addValidationError(new ValidationError(ERROR_GRAPHIC_OUTPUT_INTENT_INVALID_ENTRY,
                     "/N entry of ICC profile is different (" + iccBased.getNumberOfComponents()
                     + ") than alternate entry colorspace component count ("
-                    + altCS.getNumberOfComponents() + ")"));
+                    + alternateColorSpace.getNumberOfComponents() + ")"));
         }
     }
 }