Fix server empty thread name #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
16 chars is not a ton but is useful still, maybe there could be an option to disable this, and we would default it to false to keep the old behavior. |
Contributor
Author
|
@bsergean Fix the problem that the server thread name is empty, and keep the old behavior. Add option to disable automatic update of thread name. |
Contributor
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setThreadName in WebSocket::run will overwrite the previously set Srv::ws:, and getUrl is empty at this time, resulting in an empty thread name. For the client, 16 characters are not enough to represent very valid information in Linux. So delete setThreadName in WebSocket::run