Skip to content

Commit f34069c

Browse files
authored
fix(clerk-js): More floating ui related fixes (clerk#2647)
1 parent 801f1de commit f34069c

File tree

5 files changed

+3
-6
lines changed

5 files changed

+3
-6
lines changed

.changeset/forty-trains-rest.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/clerk-js/src/ui/elements/Menu.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ export const MenuList = (props: MenuListProps) => {
113113
context={context}
114114
nodeId={nodeId}
115115
isOpen={isOpen}
116-
order={['floating', 'content']}
117116
portal={asPortal}
118117
>
119118
<Col
@@ -122,7 +121,6 @@ export const MenuList = (props: MenuListProps) => {
122121
ref={containerRef}
123122
role='menu'
124123
onKeyDown={onKeyDown}
125-
tabIndex={0}
126124
sx={[
127125
theme => ({
128126
backgroundColor: colors.makeSolid(theme.colors.$colorBackground),

packages/clerk-js/src/ui/elements/Modal.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const Modal = withFloatingTree((props: ModalProps) => {
4747
nodeId={nodeId}
4848
context={context}
4949
isOpen={isOpen}
50-
order={['floating', 'content']}
5150
>
5251
<ModalContext.Provider value={modalCtx}>
5352
<Flex
@@ -75,7 +74,6 @@ export const Modal = withFloatingTree((props: ModalProps) => {
7574
<Flex
7675
elementDescriptor={descriptors.modalContent}
7776
ref={floating}
78-
tabIndex={0}
7977
aria-modal='true'
8078
role='dialog'
8179
sx={[

packages/clerk-js/src/ui/elements/Navbar.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ const MobileNavbarContainer = withFloatingTree((props: React.PropsWithChildren<R
205205
nodeId={nodeId}
206206
context={context}
207207
isOpen={isOpen}
208-
order={['floating', 'content']}
209208
portal={false}
210209
>
211210
<Col

packages/clerk-js/src/ui/elements/Popover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type PopoverProps = PropsWithChildren<{
1313
}>;
1414

1515
export const Popover = (props: PopoverProps) => {
16-
const { context, initialFocus, order = ['reference', 'content'], nodeId, isOpen, portal = true, children } = props;
16+
const { context, initialFocus, order = ['floating', 'content'], nodeId, isOpen, portal = true, children } = props;
1717

1818
if (portal) {
1919
return (

0 commit comments

Comments
 (0)