Change userland detection to reflect all item types #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming you've tested this since and working in your environment? I forgot about this until just now. |
|
Yes. I tested ths modification and deployed it. |
MichalMMac
force-pushed
the
fix-userland
branch
from
8b7c3b3 to
9f11281
Compare
|
@MichalMMac please rebase of latest master for python3 and see if you can get this sorted. Sorry about not merging this prior. |
MichalMMac
force-pushed
the
fix-userland
branch
from
9f11281 to
1373c07
Compare
|
Done. |
|
and assumed it's tested? |
erikng
requested changes
Dec 6, 2019
| if stage == 'userland': | ||
| if len(iajson['userland']) > 0: | ||
| while (getconsoleuser()[0] is None | ||
| or getconsoleuser()[0] == u'loginwindow' |
There was a problem hiding this comment.
don't think we need the unicode force on the string, considering it wasn't needed in my new postinstall
There was a problem hiding this comment.
Missed that during rebase. Thanks. -> fcd2778
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for #48
Code responsible for sleeping is moved from package if/else branch to the function body.
Other userland items such as
rootscriptshould not start before user is logged into the console.