Skip to content

Adding ethernet support #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Foxei
Copy link

@Foxei Foxei commented Jan 20, 2024

We have added Ethernet support to the mros2-esp32 project. The required changes closely resemble the code in the microROS project. Additionally, I have included a Kconfig.projbuild file to facilitate the switching between interfaces and configuration of the interfaces as needed.

@takasehideki
Copy link
Member

takasehideki commented Dec 29, 2024

@Foxei We deeply apologize that we couldn't reply to this your PR for a long time,,, To be honest, we have been busy with other tasks and have been away from mros2 development for a while, so I was not aware of your great contribution,,, I hope you can forgive me.

As you may have noticed, we have received another PR #27 similar to your proposal. I think the difference is whether the use of Ethernet is applied to the whole or the individual example.
I assume that we usually think of the Wi-Fi communication when we want to employ the ESP32 family, and that using Ethernet is not a so common case. For this reason, I think it is better to provide a dedicated guide for those who wish to use it for this special case.
Also, I believe the instructions should be as easy as possible. Some first-time users may be unfamiliar with menuconfig and may feel uneasy. This is also the reason why IPv6 can be disabled using only standard operations with idf.py (see here).

If you are still interested in adding this feature, I would be glad to receive your comments and suggestions at #27 .

@takasehideki
Copy link
Member

By the way, your commit to bump mros2 v.0.53 is very interesting.
4e03ea4

I think you could confirm this worked fine. So I will create another PR to track this.

@takasehideki takasehideki mentioned this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants