Create a new embedding by PUT

Follow the unusual patter from PUT /collections/:collection_name:
objects are created by PUT /place/<name>

Instead of POST /collections/:collection_name/insert,
use PUT /collections/:collection_name/embeddings/:embedding_id.

Author: prantlf

src/db.rs

@@ -34,12 +34,15 @@ pub enum Error {
 
 #[derive(Debug, serde::Serialize, serde::Deserialize)]
 pub struct Db {
+	/// Collections in the database
 	pub collections: HashMap<String, Collection>,
 }
 
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize, JsonSchema)]
 pub struct SimilarityResult {
+	/// Similarity score
 	score: f32,
+	/// Matching embedding
 	embedding: Embedding,
 }
 
@@ -197,8 +200,11 @@ fn match_embedding(embedding: &Embedding, filter: &[HashMap<String, String>]) ->
 
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize, JsonSchema)]
 pub struct Embedding {
+	/// Unique identifier
 	pub id: String,
+	/// Vector computed from a text chunk
 	pub vector: Vec<f32>,
+	/// Metadata about the source text
 	pub metadata: Option<HashMap<String, String>>,
 }
 

src/routes/collection.rs

@@ -25,10 +25,10 @@ pub fn handler() -> ApiRouter {
 			.api_route("/:collection_name", post(query_collection))
 			.api_route("/:collection_name", get(get_collection_info))
 			.api_route("/:collection_name", delete(delete_collection))
-			.api_route("/:collection_name/insert", post(insert_into_collection))
 			.api_route("/:collection_name/embeddings", get(get_embeddings))
 			.api_route("/:collection_name/embeddings", post(query_embeddings))
 			.api_route("/:collection_name/embeddings", delete(delete_embeddings))
+			.api_route("/:collection_name/embeddings/:embedding_id", put(insert_into_collection))
 			.api_route("/:collection_name/embeddings/:embedding_id", get(get_embedding))
 			.api_route("/:collection_name/embeddings/:embedding_id", delete(delete_embedding)),
 	)
@@ -162,16 +162,29 @@ async fn delete_collection(
 	}
 }
 
+#[derive(Debug, serde::Deserialize, JsonSchema)]
+struct EmbeddingData {
+	/// Vector computed from a text chunk
+	vector: Vec<f32>,
+	/// Metadata about the source text
+	metadata: Option<HashMap<String, String>>,
+}
+
 /// Insert a vector into a collection
 async fn insert_into_collection(
-	Path(collection_name): Path<String>,
+	Path((collection_name, embedding_id)): Path<(String, String)>,
 	Extension(db): DbExtension,
-	Json(embedding): Json<Embedding>,
+	Json(embedding_data): Json<EmbeddingData>,
 ) -> Result<StatusCode, HTTPError> {
 	tracing::trace!("Inserting into collection {collection_name}");
 
 	let mut db = db.write().await;
 
+	let embedding = Embedding {
+		id: embedding_id,
+		vector: embedding_data.vector,
+		metadata: embedding_data.metadata,
+	};
 	let insert_result = db.insert_into_collection(&collection_name, embedding);
 	drop(db);
 
@@ -263,10 +276,6 @@ async fn get_embedding(
 ) -> Result<Json<Embedding>, HTTPError> {
 	tracing::trace!("Getting {embedding_id} from collection {collection_name}");
 
-	if embedding_id.len() == 0 {
-		return Err(HTTPError::new("Embedding identifier empty").with_status(StatusCode::BAD_REQUEST));
-	}
-
 	let db = db.read().await;
 	let collection = db
 		.get_collection(&collection_name)