Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I-04] Functions increaseAllowance and decreaseAllowance are not part of canonical ERC20 #63

Closed
k1rill-fedoseev opened this issue Dec 13, 2023 · 1 comment
Closed

[I-04] Functions increaseAllowance and decreaseAllowance are not part of canonical ERC20 #63

k1rill-fedoseev opened this issue Dec 13, 2023 · 1 comment
Assignees
@PierrickGT

Comments

@k1rill-fedoseev
Copy link

[I-04] Functions increaseAllowance and decreaseAllowance are not part of canonical ERC20

There has been a recent discussion about uncertain benefits and tradeoffs of supporting increaseAllowance
and decreaseAllowance in ERC20-compliant tokens.
See OpenZeppelin/openzeppelin-contracts#4583. As a result, functions increaseAllowance
and decreaseAllowance are no longer included in a widely used OpenZeppelin ERC20 implementation. Consider removing
them from ERC20Permit implementation as well.
@PierrickGT PierrickGT mentioned this issue Dec 18, 2023
Merged
@PierrickGT
Copy link
Member

Fixed by: m0-foundation/common#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickGT PierrickGT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PierrickGT @k1rill-fedoseev