Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Not Display #1

Open
ThreeWaterGG opened this issue Oct 30, 2019 · 6 comments
Open

Can Not Display #1

ThreeWaterGG opened this issue Oct 30, 2019 · 6 comments

Comments

@ThreeWaterGG
Copy link

I'm a novice and interesting for your excellent work.But there are some puzzles when I tried to run the code following the introduction.First,I compiled the Skye.sln and there are some errors,which had been solved since I change "std::experimental::filesystem" to "std::filesystem"(I think that's because my VS version is latest).Then I opened the workspace with VSCode and pressed 'ctrl+shift+b'.Though it's had been building,nothing displayed except for some warnings on terminal as shots below:
image
There was a icon on bottom but no windows display:
image
Then I change the load in 'progressive_pointcloud.js' as 'To do things',but the problems still existed.
I wonder did I miss some points or do something wrong?
Appreciate for your reply.

@m-schuetz
Copy link
Owner

Hi! Seems like the window might still be opened on the second monitor by default so if you just have one monitor, it won't show up. As soon as you ctrl+s save progressive_pointcloud.js, it should be moved to the main monitor, though. You might then have to select it again from the taskbar to make sure it's also on top.

These are the relevant lines in progressive_pointcloud.js that move the window to the main monitor:

window.x = window.monitors[0].width * 0.1;
window.y = window.monitors[0].height * 0.1;
window.width = window.monitors[0].width * 0.8;
window.height = window.monitors[0].height * 0.8;

As for the "too slow" messages, did you already load a point cloud or does it display that message even without any point cloud loaded? What GPU do you have?

@ThreeWaterGG
Copy link
Author

ThreeWaterGG commented Oct 31, 2019

Really appreciate for your patience.Sorry about the misunderstandings of my screenshot.Actually the window be opened on the main monitor by default,like this:
image
And you can see nothing display on desktop.
I check the file then.I load a small las file with 4.6M,and the path is correct.
image
Then I delete the file and try to load nothing,the messages on terminal unchanged.
image
The 'strat.js' was executed.Every time it enters first render loop,the 'slow' messages shows up.I doubt it didn't execute to the 'progressive_pointcloud.js' perhaps?
The GPU I have is AMD Radeon R5 430,I can open my file with CloudCompare easily.
Then I run the code on a machine with GTX 2070.The 'too slow' messages showed up quicker than before indeed,but still nothing appeared.

@m-schuetz
Copy link
Owner

m-schuetz commented Oct 31, 2019

The first couple of "too slow" during start up are okay, but if that happens every frame there is likely something wrong somewhere. Can't really debug this over github. I can, however, take a look at your las file and see if it works for me. The whole application is a prototype that was implemented only with our own data in mind, so the loader may not be capable of loading any kind of las file. If you can send me the file or a link to mschuetz@potree.org I will take a look at it. Might take a couple of days, though.

A potential issue that comes to mind are las files that store coordinates in non-euclidean coordinates, e.g. in lat/long/elevation. Coordinates must be XYZ.

Edit: Did you also press "ctrl+s" with "progressive_pointcloud.js" open, and did the console show that it's doing some work? You'll have to press ctrl+s at runtime, because progressive_pointcloud.js is not executed automatically. Only start.js is.

@Kapsler
Copy link

Kapsler commented Nov 7, 2019

EDIT: Follow up: When I change the output color in reproject.fs to be vec4(1, 0, 0, 1) the model is visible, just in red. So apparently the color is not correctly read from the .las file generated by txt2las!

Hey Markus,
I have a very similar problem to ThreeWaterGG.
When using the laz file you recommended (ot_35121F2416A_1.laz) and converting it to .las with las2las, everything works fine.
But when I used a .las file i generated with txt2las from a .xyz I don't get any rendering. (Black screen)
I see that my GPU is working with about 99% usage, but the screen remains empty.
I can't send you the .las file, as it is confidential, but here is the output from Skye. (The point count seems to be correct)
image

Maybe try using txt2las with some .xyz file.
Mine is in the xyzRGB format.
(i.e. 21.00420000 -9.03340000 111.55230000 217 218 211)

@m-schuetz
Copy link
Owner

m-schuetz commented Nov 7, 2019

@R0bbe

We're currently not checking whether 1 or 2 bytes of the red, green and blue channels are used. If everything is black, it might be because Skye assumes colors are stored in 2 bytes in the LAS, and it then divides color values by 256 to reduce them to one byte. If colors are only stored in 1 byte, they'll all end up being 0 after that divsion.

You can try to remove the devision by 256 here:
https://github.com/m-schuetz/Skye/blob/master/modules/progressive/LASLoader.h#L994

@Kapsler
Copy link

Kapsler commented Nov 8, 2019

@m-schuetz that worked for this case, thanks! I also can't load .bin files generated with the las2bin.js tool, but that's not important right now. Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants