From 953f53921505a884f3912f2d8db5217a71c0479a Mon Sep 17 00:00:00 2001 From: Maxim Dounin Date: Thu, 5 Dec 2019 19:38:06 +0300 Subject: [PATCH] Upstream keepalive: clearing of c->data in cached connections. Previously, connections returned from keepalive cache had c->data pointing to the keepalive cache item. While this shouldn't be a problem for correct code, as c->data is not expected to be used before it is set, explicitly clearing it might help to avoid confusion. --- src/http/modules/ngx_http_upstream_keepalive_module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/http/modules/ngx_http_upstream_keepalive_module.c b/src/http/modules/ngx_http_upstream_keepalive_module.c index bdc4ae5c7..1560807c6 100644 --- a/src/http/modules/ngx_http_upstream_keepalive_module.c +++ b/src/http/modules/ngx_http_upstream_keepalive_module.c @@ -275,6 +275,7 @@ ngx_http_upstream_get_keepalive_peer(ngx_peer_connection_t *pc, void *data) c->idle = 0; c->sent = 0; + c->data = NULL; c->log = pc->log; c->read->log = pc->log; c->write->log = pc->log;