SocketIO update to 4.5.0 #1817
SocketIO update to 4.5.0 #1817
Conversation
Added workflow for video crop
There was a problem hiding this comment.
@Arri98 Looking good :-)
We should update package lock files, too, but it might be better to wait until #1818 has been merged, so we can base this PR on the new lock file format.
I noticed that spine also uses the socket.io-client library. It might make sense to update it also in this PR (so that perftest are in sync with erizo).
| @@ -15,8 +15,8 @@ | |||
| "node-getopt": "~0.3.2", | |||
| "prom-client": "~11.2.1", | |||
| "sdp-transform": "~2.14.0", | |||
| "socket.io": "~2.4.0", | |||
| "socket.io-client": "~2.4.0", | |||
| "socket.io": "~4.5.0", | |||
There was a problem hiding this comment.
We should also update package-lock.json.
| @@ -15,7 +15,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^5.1.0", | |||
| "eslint-plugin-react": "^7.1.0", | |||
| "expose-loader": "~0.7.5", | |||
| "google-closure-compiler-js": "~20170521.0.0", | |||
| "google-closure-compiler": "~20220502.0.0", | |||
There was a problem hiding this comment.
We should also update package-lock.json.
|
@Arri98 @lodoyun We have been testing this change (rebased on the nodejs upgrade, PR #1817) for a while. We have performed a load test using a single stream with up to 1200 concurrent subscribers:
and have observed no signalling issues. We have also been dogfooding the change in our internal environment, which exposes it to a higher variety of browser/OS combinations (Win/Linux/Mac, Chrome/Firefox/Safari). No issues have been observed, either. |
|
Some events (https://socket.io/docs/v4/emit-cheatsheet/) and event error handling (https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#a-middleware-error-will-now-emit-an-error-object) changed from v2 to v3 and caused issues when a socket disconnected. I will update this PR after solving the issues. |
| @@ -24,8 +24,8 @@ const erizoTasks = (gulp, plugins, config) => { | |||
| .pipe(plugins.sourcemaps.init()) | |||
| .pipe(plugins.closureCompiler({ | |||
| warning_level: 'QUIET', | |||
| languageIn: 'ECMASCRIPT6', | |||
| languageOut: 'ECMASCRIPT5', | |||
| languageIn: 'ECMASCRIPT_2017', | |||
| log.warning(`message: socket error, id: ${that.id}, state: ${that.state.toString()}, error: ${err}`); | ||
| reliableSocket.on('connect_error', (err) => { | ||
| // Fired when an namespace middleware error occurs. | ||
| log.warning(`message: connect_error error, id: ${that.id}, state: ${that.state.toString()}, error: ${err}`); |
Updated socketIO to version 4.5.0 as the 2.4.0 was deprecated. For this the google-closure-compiler had to be updated as the new version of SocketIO used JS features that the compiler didn't support.
[Yes] It needs and includes Unit Tests
Updated test to account for changes in the socketIO API.
[] It includes documentation for these changes in
/doc.