Skip to content

Commit d7d6ae9

Browse files
author
Jefersson Nathan
committed
Replace hardcoded FQCN with use of ::class magic constant
1 parent b0aacff commit d7d6ae9

File tree

9 files changed

+61
-47
lines changed

9 files changed

+61
-47
lines changed

lib/Doctrine/ODM/MongoDB/Configuration.php

+6-3
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
use Doctrine\Common\Annotations\AnnotationReader;
2323
use Doctrine\Common\Cache\Cache;
2424
use Doctrine\Common\Persistence\Mapping\Driver\MappingDriver;
25+
use Doctrine\Common\Persistence\ObjectRepository;
26+
use Doctrine\ODM\MongoDB\DocumentRepository;
27+
use Doctrine\ODM\MongoDB\Mapping\ClassMetadataFactory;
2528
use Doctrine\ODM\MongoDB\Mapping\Driver\AnnotationDriver;
2629
use Doctrine\ODM\MongoDB\Repository\DefaultRepositoryFactory;
2730
use Doctrine\ODM\MongoDB\Repository\RepositoryFactory;
@@ -356,7 +359,7 @@ public function setClassMetadataFactoryName($cmfName)
356359
public function getClassMetadataFactoryName()
357360
{
358361
if ( ! isset($this->attributes['classMetadataFactoryName'])) {
359-
$this->attributes['classMetadataFactoryName'] = 'Doctrine\ODM\MongoDB\Mapping\ClassMetadataFactory';
362+
$this->attributes['classMetadataFactoryName'] = ClassMetadataFactory::class;
360363
}
361364
return $this->attributes['classMetadataFactoryName'];
362365
}
@@ -441,7 +444,7 @@ public function setDefaultRepositoryClassName($className)
441444
{
442445
$reflectionClass = new \ReflectionClass($className);
443446

444-
if ( ! $reflectionClass->implementsInterface('Doctrine\Common\Persistence\ObjectRepository')) {
447+
if ( ! $reflectionClass->implementsInterface(ObjectRepository::class)) {
445448
throw MongoDBException::invalidDocumentRepository($className);
446449
}
447450

@@ -457,7 +460,7 @@ public function getDefaultRepositoryClassName()
457460
{
458461
return isset($this->attributes['defaultRepositoryClassName'])
459462
? $this->attributes['defaultRepositoryClassName']
460-
: 'Doctrine\ODM\MongoDB\DocumentRepository';
463+
: DocumentRepository::class;
461464
}
462465

463466
/**

lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadataInfo.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
namespace Doctrine\ODM\MongoDB\Mapping;
2121

22+
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
2223
use Doctrine\ODM\MongoDB\Utility\CollectionHelper;
2324
use Doctrine\ODM\MongoDB\LockException;
2425
use Doctrine\ODM\MongoDB\Mapping\MappingException;
@@ -1127,7 +1128,7 @@ public function mapField(array $mapping)
11271128
$mapping['name'] = '_id';
11281129
$this->identifier = $mapping['fieldName'];
11291130
if (isset($mapping['strategy'])) {
1130-
$this->generatorType = constant('Doctrine\ODM\MongoDB\Mapping\ClassMetadata::GENERATOR_TYPE_' . strtoupper($mapping['strategy']));
1131+
$this->generatorType = constant(ClassMetadata::class . '::GENERATOR_TYPE_' . strtoupper($mapping['strategy']));
11311132
}
11321133
$this->generatorOptions = isset($mapping['options']) ? $mapping['options'] : array();
11331134
switch ($this->generatorType) {

lib/Doctrine/ODM/MongoDB/Mapping/Driver/AnnotationDriver.php

+14-8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@
2626
use Doctrine\Common\Persistence\Mapping\Driver\AnnotationDriver as AbstractAnnotationDriver;
2727
use Doctrine\ODM\MongoDB\Events;
2828
use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
29+
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document;
30+
use Doctrine\ODM\MongoDB\Mapping\Annotations\EmbeddedDocument;
31+
use Doctrine\ODM\MongoDB\Mapping\Annotations\HasLifecycleCallbacks;
32+
use Doctrine\ODM\MongoDB\Mapping\Annotations\MappedSuperclass;
33+
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata as MappingClassMetadata;
2934
use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
3035
use Doctrine\ODM\MongoDB\Mapping\MappingException;
3136

@@ -35,13 +40,14 @@
3540
* @since 1.0
3641
* @author Jonathan H. Wage <jonwage@gmail.com>
3742
* @author Roman Borschel <roman@code-factory.org>
43+
* @author Jefersson Nathan <malukenho@phpse.net>
3844
*/
3945
class AnnotationDriver extends AbstractAnnotationDriver
4046
{
4147
protected $entityAnnotationClasses = array(
42-
'Doctrine\\ODM\\MongoDB\\Mapping\\Annotations\\Document' => 1,
43-
'Doctrine\\ODM\\MongoDB\\Mapping\\Annotations\\MappedSuperclass' => 2,
44-
'Doctrine\\ODM\\MongoDB\\Mapping\\Annotations\\EmbeddedDocument' => 3,
48+
Document::class => 1,
49+
MappedSuperclass::class => 2,
50+
EmbeddedDocument::class => 3,
4551
);
4652

4753
/**
@@ -84,7 +90,7 @@ public function loadMetadataForClass($className, ClassMetadata $class)
8490
$this->addIndex($class, $index);
8591
}
8692
} elseif ($annot instanceof ODM\InheritanceType) {
87-
$class->setInheritanceType(constant('Doctrine\\ODM\\MongoDB\\Mapping\\ClassMetadata::INHERITANCE_TYPE_'.$annot->value));
93+
$class->setInheritanceType(constant(MappingClassMetadata::class . '::INHERITANCE_TYPE_'.$annot->value));
8894
} elseif ($annot instanceof ODM\DiscriminatorField) {
8995
// $fieldName property is deprecated, but fall back for BC
9096
if (isset($annot->value)) {
@@ -99,7 +105,7 @@ public function loadMetadataForClass($className, ClassMetadata $class)
99105
} elseif ($annot instanceof ODM\DiscriminatorValue) {
100106
$class->setDiscriminatorValue($annot->value);
101107
} elseif ($annot instanceof ODM\ChangeTrackingPolicy) {
102-
$class->setChangeTrackingPolicy(constant('Doctrine\\ODM\\MongoDB\\Mapping\\ClassMetadata::CHANGETRACKING_'.$annot->value));
108+
$class->setChangeTrackingPolicy(constant(MappingClassMetadata::class . '::CHANGETRACKING_'.$annot->value));
103109
} elseif ($annot instanceof ODM\DefaultDiscriminatorValue) {
104110
$class->setDefaultDiscriminatorValue($annot->value);
105111
}
@@ -114,9 +120,9 @@ public function loadMetadataForClass($className, ClassMetadata $class)
114120
ksort($documentAnnots);
115121
$documentAnnot = reset($documentAnnots);
116122

117-
if ($documentAnnot instanceof ODM\MappedSuperclass) {
123+
if ($documentAnnot instanceof MappedSuperclass) {
118124
$class->isMappedSuperclass = true;
119-
} elseif ($documentAnnot instanceof ODM\EmbeddedDocument) {
125+
} elseif ($documentAnnot instanceof EmbeddedDocument) {
120126
$class->isEmbeddedDocument = true;
121127
}
122128
if (isset($documentAnnot->db)) {
@@ -199,7 +205,7 @@ public function loadMetadataForClass($className, ClassMetadata $class)
199205
$class->registerAlsoLoadMethod($method->getName(), $annot->value);
200206
}
201207

202-
if ( ! isset($classAnnotations['Doctrine\ODM\MongoDB\Mapping\Annotations\HasLifecycleCallbacks'])) {
208+
if ( ! isset($classAnnotations[HasLifecycleCallbacks::class])) {
203209
continue;
204210
}
205211

lib/Doctrine/ODM/MongoDB/Mapping/Driver/XmlDriver.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
use Doctrine\Common\Persistence\Mapping\ClassMetadata;
2323
use Doctrine\Common\Persistence\Mapping\Driver\FileDriver;
24+
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata as MappingClassMetadata;
2425
use Doctrine\ODM\MongoDB\Utility\CollectionHelper;
2526
use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
2627

@@ -30,6 +31,7 @@
3031
* @since 1.0
3132
* @author Jonathan H. Wage <jonwage@gmail.com>
3233
* @author Roman Borschel <roman@code-factory.org>
34+
* @author Jefersson Nathan <malukenho@phpse.net>
3335
*/
3436
class XmlDriver extends FileDriver
3537
{
@@ -87,10 +89,10 @@ public function loadMetadataForClass($className, ClassMetadata $class)
8789
}
8890
if (isset($xmlRoot['inheritance-type'])) {
8991
$inheritanceType = (string) $xmlRoot['inheritance-type'];
90-
$class->setInheritanceType(constant('Doctrine\ODM\MongoDB\Mapping\ClassMetadata::INHERITANCE_TYPE_' . $inheritanceType));
92+
$class->setInheritanceType(constant(MappingClassMetadata::class . '::INHERITANCE_TYPE_' . $inheritanceType));
9193
}
9294
if (isset($xmlRoot['change-tracking-policy'])) {
93-
$class->setChangeTrackingPolicy(constant('Doctrine\ODM\MongoDB\Mapping\ClassMetadata::CHANGETRACKING_' . strtoupper((string) $xmlRoot['change-tracking-policy'])));
95+
$class->setChangeTrackingPolicy(constant(MappingClassMetadata::class . '::CHANGETRACKING_' . strtoupper((string) $xmlRoot['change-tracking-policy'])));
9496
}
9597
if (isset($xmlRoot->{'discriminator-field'})) {
9698
$discrField = $xmlRoot->{'discriminator-field'};

lib/Doctrine/ODM/MongoDB/Mapping/Driver/YamlDriver.php

+4-3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
use Doctrine\Common\Persistence\Mapping\ClassMetadata;
2323
use Doctrine\Common\Persistence\Mapping\Driver\FileDriver;
24+
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata as MappingClassMetadata;
2425
use Doctrine\ODM\MongoDB\Utility\CollectionHelper;
2526
use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
2627
use Symfony\Component\Yaml\Yaml;
@@ -31,6 +32,7 @@
3132
* @since 1.0
3233
* @author Jonathan H. Wage <jonwage@gmail.com>
3334
* @author Roman Borschel <roman@code-factory.org>
35+
* @author Jefersson Nathan <malukenho@phpse.net>
3436
*/
3537
class YamlDriver extends FileDriver
3638
{
@@ -80,7 +82,7 @@ public function loadMetadataForClass($className, ClassMetadata $class)
8082
}
8183
}
8284
if (isset($element['inheritanceType'])) {
83-
$class->setInheritanceType(constant('Doctrine\ODM\MongoDB\Mapping\ClassMetadata::INHERITANCE_TYPE_' . strtoupper($element['inheritanceType'])));
85+
$class->setInheritanceType(constant(MappingClassMetadata::class . '::INHERITANCE_TYPE_' . strtoupper($element['inheritanceType'])));
8486
}
8587
if (isset($element['discriminatorField'])) {
8688
$class->setDiscriminatorField($this->parseDiscriminatorField($element['discriminatorField']));
@@ -92,8 +94,7 @@ public function loadMetadataForClass($className, ClassMetadata $class)
9294
$class->setDefaultDiscriminatorValue($element['defaultDiscriminatorValue']);
9395
}
9496
if (isset($element['changeTrackingPolicy'])) {
95-
$class->setChangeTrackingPolicy(constant('Doctrine\ODM\MongoDB\Mapping\ClassMetadata::CHANGETRACKING_'
96-
. strtoupper($element['changeTrackingPolicy'])));
97+
$class->setChangeTrackingPolicy(constant(MappingClassMetadata::class . '::CHANGETRACKING_' . strtoupper($element['changeTrackingPolicy'])));
9798
}
9899
if (isset($element['requireIndexes'])) {
99100
$class->setRequireIndexes($element['requireIndexes']);

lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,7 @@ public function prepareQueryOrNewObj(array $query)
931931
list($key, $value) = $this->prepareQueryElement($key, $value, null, true);
932932

933933
$preparedQuery[$key] = is_array($value)
934-
? array_map('Doctrine\ODM\MongoDB\Types\Type::convertPHPToDatabaseValue', $value)
934+
? array_map('\Doctrine\ODM\MongoDB\Types\Type::convertPHPToDatabaseValue', $value)
935935
: Type::convertPHPToDatabaseValue($value);
936936
}
937937

lib/Doctrine/ODM/MongoDB/Proxy/ProxyFactory.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
use Doctrine\Common\Proxy\Proxy as BaseProxy;
3131
use Doctrine\Common\Persistence\Mapping\ClassMetadata as BaseClassMetadata;
3232
use Doctrine\ODM\MongoDB\Persisters\DocumentPersister;
33+
use Doctrine\ODM\MongoDB\Proxy\Proxy;
3334
use ReflectionProperty;
3435

3536
/**
@@ -75,7 +76,7 @@ public function __construct(DocumentManager $documentManager, $proxyDir, $proxyN
7576
$this->proxyNamespace = $proxyNamespace;
7677
$proxyGenerator = new ProxyGenerator($proxyDir, $proxyNamespace);
7778

78-
$proxyGenerator->setPlaceholder('baseProxyInterface', 'Doctrine\ODM\MongoDB\Proxy\Proxy');
79+
$proxyGenerator->setPlaceholder('baseProxyInterface', Proxy::class);
7980

8081
parent::__construct($proxyGenerator, $this->metadataFactory, $autoGenerate);
8182
}

lib/Doctrine/ODM/MongoDB/Query/Query.php

+1-3
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
use Doctrine\MongoDB\Collection;
2323
use Doctrine\MongoDB\Cursor as BaseCursor;
2424
use Doctrine\MongoDB\CursorInterface;
25-
use Doctrine\MongoDB\EagerCursor as BaseEagerCursor;
26-
use Doctrine\MongoDB\Iterator;
2725
use Doctrine\ODM\MongoDB\Cursor;
2826
use Doctrine\ODM\MongoDB\DocumentManager;
2927
use Doctrine\ODM\MongoDB\EagerCursor;
@@ -296,7 +294,7 @@ protected function prepareCursor(BaseCursor $cursor)
296294
$cursor = parent::prepareCursor($cursor);
297295

298296
// Convert the base Cursor into an ODM Cursor
299-
$cursorClass = ( ! empty($this->query['eagerCursor'])) ? 'Doctrine\ODM\MongoDB\EagerCursor' : 'Doctrine\ODM\MongoDB\Cursor';
297+
$cursorClass = ( ! empty($this->query['eagerCursor'])) ? EagerCursor::class : Cursor::class;
300298
$cursor = new $cursorClass($cursor, $this->dm->getUnitOfWork(), $this->class);
301299

302300
$cursor->hydrate($this->hydrate);

lib/Doctrine/ODM/MongoDB/Types/Type.php

+27-25
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@
2020
namespace Doctrine\ODM\MongoDB\Types;
2121

2222
use Doctrine\ODM\MongoDB\Mapping\MappingException;
23+
use Doctrine\ODM\MongoDB\Types;
2324

2425
/**
2526
* The Type interface.
2627
*
2728
* @since 1.0
2829
* @author Jonathan H. Wage <jonwage@gmail.com>
2930
* @author Roman Borschel <roman@code-factory.org>
31+
* @author Jefersson Nathan <malukenho@phpse.net>
3032
*/
3133
abstract class Type
3234
{
@@ -61,31 +63,31 @@ abstract class Type
6163

6264
/** The map of supported doctrine mapping types. */
6365
private static $typesMap = array(
64-
self::ID => 'Doctrine\ODM\MongoDB\Types\IdType',
65-
self::INTID => 'Doctrine\ODM\MongoDB\Types\IntIdType',
66-
self::CUSTOMID => 'Doctrine\ODM\MongoDB\Types\CustomIdType',
67-
self::BOOL => 'Doctrine\ODM\MongoDB\Types\BooleanType',
68-
self::BOOLEAN => 'Doctrine\ODM\MongoDB\Types\BooleanType',
69-
self::INT => 'Doctrine\ODM\MongoDB\Types\IntType',
70-
self::INTEGER => 'Doctrine\ODM\MongoDB\Types\IntType',
71-
self::FLOAT => 'Doctrine\ODM\MongoDB\Types\FloatType',
72-
self::STRING => 'Doctrine\ODM\MongoDB\Types\StringType',
73-
self::DATE => 'Doctrine\ODM\MongoDB\Types\DateType',
74-
self::KEY => 'Doctrine\ODM\MongoDB\Types\KeyType',
75-
self::TIMESTAMP => 'Doctrine\ODM\MongoDB\Types\TimestampType',
76-
self::BINDATA => 'Doctrine\ODM\MongoDB\Types\BinDataType',
77-
self::BINDATAFUNC => 'Doctrine\ODM\MongoDB\Types\BinDataFuncType',
78-
self::BINDATABYTEARRAY => 'Doctrine\ODM\MongoDB\Types\BinDataByteArrayType',
79-
self::BINDATAUUID => 'Doctrine\ODM\MongoDB\Types\BinDataUUIDType',
80-
self::BINDATAUUIDRFC4122 => 'Doctrine\ODM\MongoDB\Types\BinDataUUIDRFC4122Type',
81-
self::BINDATAMD5 => 'Doctrine\ODM\MongoDB\Types\BinDataMD5Type',
82-
self::BINDATACUSTOM => 'Doctrine\ODM\MongoDB\Types\BinDataCustomType',
83-
self::FILE => 'Doctrine\ODM\MongoDB\Types\FileType',
84-
self::HASH => 'Doctrine\ODM\MongoDB\Types\HashType',
85-
self::COLLECTION => 'Doctrine\ODM\MongoDB\Types\CollectionType',
86-
self::INCREMENT => 'Doctrine\ODM\MongoDB\Types\IncrementType',
87-
self::OBJECTID => 'Doctrine\ODM\MongoDB\Types\ObjectIdType',
88-
self::RAW => 'Doctrine\ODM\MongoDB\Types\RawType',
66+
self::ID => Types\IdType::class,
67+
self::INTID => Types\IntIdType::class,
68+
self::CUSTOMID => Types\CustomIdType::class,
69+
self::BOOL => Types\BooleanType::class,
70+
self::BOOLEAN => Types\BooleanType::class,
71+
self::INT => Types\IntType::class,
72+
self::INTEGER => Types\IntType::class,
73+
self::FLOAT => Types\FloatType::class,
74+
self::STRING => Types\StringType::class,
75+
self::DATE => Types\DateType::class,
76+
self::KEY => Types\KeyType::class,
77+
self::TIMESTAMP => Types\TimestampType::class,
78+
self::BINDATA => Types\BinDataType::class,
79+
self::BINDATAFUNC => Types\BinDataFuncType::class,
80+
self::BINDATABYTEARRAY => Types\BinDataByteArrayType::class,
81+
self::BINDATAUUID => Types\BinDataUUIDType::class,
82+
self::BINDATAUUIDRFC4122 => Types\BinDataUUIDRFC4122Type::class,
83+
self::BINDATAMD5 => Types\BinDataMD5Type::class,
84+
self::BINDATACUSTOM => Types\BinDataCustomType::class,
85+
self::FILE => Types\FileType::class,
86+
self::HASH => Types\HashType::class,
87+
self::COLLECTION => Types\CollectionType::class,
88+
self::INCREMENT => Types\IncrementType::class,
89+
self::OBJECTID => Types\ObjectIdType::class,
90+
self::RAW => Types\RawType::class,
8991
);
9092

9193
/* Prevent instantiation and force use of the factory method. */

0 commit comments

Comments
 (0)