Change how type import/export specifiers are sorted #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124.
Before –
type
specifiers come first:After – all specifiers are sorted alphabetically, regardless of
type
:Motivation:
You might import a class for a type annotation using:
Later, you also start instantiating that class in the same file (
new MyClass()
), so you removetype
.Previously, this resulted in a messy diff due to the class moving:
Now it results in just the
type
keyword being removed:This is consistent with https://github.com/lydell/eslint-plugin-simple-import-sort#why-sort-on-from