[Unimportant feature request] Changing the title of File menu-bar item?

[tsujan]

I was searching for a good replacement for Qps' "Command" menu-bar item and saw that QTerminal had a "File" menu-bar item. Since there is no file operation under that title, I think we might want to change it.

I know that seeing "File" as the first menu-bar item is a sort of tradition, but sometimes it's too irrelevant ;)

IMHO, "Session" would be much more relevant than "File".

[stefonarch]

We need more items for a menu "File" than just "exit".
QTerminal has the preferences there, so we could at least move that, so we'd have "exit" and "preferences".

Or we find some useful commands. Is there any draft in the code left for what it was thought for initially?

[tsujan]

Or we find some useful commands

QPs shouldn't be for running commands. It's full of strange ideas and stranger codes. It should just be cleaned up, IMO.

Let's not make @yan12125 angry by talking about Qps here ;) This report is about "File" in QTerminal.

[stefonarch]

Oops, I completely misunderstood starting from your first line, thought it was about changing "command" in qps.

"Session" looks good to me.

[tsujan]

My fault. I meant that "File" in QTerminal was as bad as "Command" in Qps.

[yan12125]

File is indeed kind of strange, and Session sounds better.

As a record, here are actions added to the File menu.

qterminal/src/mainwindow.cpp

Lines 355 to 388 in 27f2e7c

	void MainWindow::setup_FileMenu_Actions()
	{
	menu_File->clear();
	setup_Action(ADD_TAB, new QAction(QIcon::fromTheme(QStringLiteral("list-add")), tr("&New Tab"), settingOwner),
	ADD_TAB_SHORTCUT, this, SLOT(addNewTab()), menu_File);
	if (presetsMenu == nullptr) {
	presetsMenu = new QMenu(tr("New Tab From &Preset"), this);
	presetsMenu->addAction(QIcon(), tr("1 &Terminal"),
	this, SLOT(addNewTab()));
	presetsMenu->addAction(QIcon(), tr("2 &Horizontal Terminals"),
	consoleTabulator, SLOT(preset2Horizontal()));
	presetsMenu->addAction(QIcon(), tr("2 &Vertical Terminals"),
	consoleTabulator, SLOT(preset2Vertical()));
	presetsMenu->addAction(QIcon(), tr("4 Terminal&s"),
	consoleTabulator, SLOT(preset4Terminals()));
	}
	menu_File->addMenu(presetsMenu);
	setup_Action(CLOSE_TAB, new QAction(QIcon::fromTheme(QStringLiteral("list-remove")), tr("&Close Tab"), settingOwner),
	CLOSE_TAB_SHORTCUT, consoleTabulator, SLOT(removeCurrentTab()), menu_File);
	setup_Action(NEW_WINDOW, new QAction(QIcon::fromTheme(QStringLiteral("window-new")), tr("&New Window"), settingOwner),
	NEW_WINDOW_SHORTCUT, this, SLOT(newTerminalWindow()), menu_File);
	menu_File->addSeparator();
	setup_Action(PREFERENCES, new QAction(tr("&Preferences..."), settingOwner), "", this, SLOT(actProperties_triggered()), menu_File);
	menu_File->addSeparator();
	setup_Action(QUIT, new QAction(QIcon::fromTheme(QStringLiteral("application-exit")), tr("&Quit"), settingOwner), "", this, SLOT(close()), menu_File);
	}