bpo-34526: Add doc examples of multiple arguments for Path.relative_to() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to make docstring clearer. |
shihai1991
reviewed
Feb 10, 2022
Doc/library/pathlib.rst
Outdated
| *other*. If it's impossible, ValueError is raised:: | ||
| Return the relative path to another path identified by *other*, each | ||
| element of *other* can be either a string representing a path segment, | ||
| a :class:`PurePath` or a subclass of :class:`PurePath`. If the operation |
There was a problem hiding this comment.
Are you sure the path segment is PurePath?
There was a problem hiding this comment.
The description here is inaccurate，I will revise it as soon
shihai1991
reviewed
Feb 11, 2022
Doc/library/pathlib.rst
Outdated
| *other*. If it's impossible, ValueError is raised:: | ||
| Return the relative path to another path identified by *other*, each | ||
| element of *other* can be either a string representing a path segment, | ||
| an object implementing the :class:`os.PathLike` interface which returns |
There was a problem hiding this comment.
I will delete the following description：an object implementing the :class:os.PathLike interface which returns a string
|
LGTM |
lvluling
pushed a commit
that referenced
this pull request
Feb 16, 2022
) Fix test_gdb.test_pycfunction() for Python built with clang -Og. Tolerate inlined functions in the gdb traceback. When _testcapimodule.c is built by clang -Og, _null_to_none() is inlined in meth_varargs() and so gdb returns _null_to_none() as the frame #1. If it's not inlined, meth_varargs() is the frame #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add doc examples with multiple arguments for Path.relative_to()
https://bugs.python.org/issue34526