SSD1306 menuconfig/kconfig broken

[neggles]

recent commit 9fed1cc conflicts somewhat with this block in kconfig:

lvgl_esp32_drivers/lvgl_tft/Kconfig

Lines 186 to 206 in 9fed1cc

	# Used in display init function to send display orientation commands
	choice DISPLAY_ORIENTATION
	prompt "Display orientation"
	default DISPLAY_ORIENTATION_PORTRAIT if !LV_TFT_DISPLAY_CONTROLLER_SSD1306
	default DISPLAY_ORIENTATION_LANDSCAPE if LV_TFT_DISPLAY_CONTROLLER_SSD1306
	config DISPLAY_ORIENTATION_PORTRAIT
	bool "Portrait" if !LV_TFT_DISPLAY_CONTROLLER_SSD1306
	config DISPLAY_ORIENTATION_PORTRAIT_INVERTED
	bool "Portrait inverted" if !LV_TFT_DISPLAY_CONTROLLER_SSD1306
	config DISPLAY_ORIENTATION_LANDSCAPE
	bool "Landscape"
	config DISPLAY_ORIENTATION_LANDSCAPE_INVERTED
	bool "Landscape inverted"
	endchoice
	config LV_DISPLAY_ORIENTATION
	int
	default 0 if DISPLAY_ORIENTATION_PORTRAIT
	default 1 if DISPLAY_ORIENTATION_PORTRAIT_INVERTED
	default 2 if DISPLAY_ORIENTATION_LANDSCAPE
	default 3 if DISPLAY_ORIENTATION_LANDSCAPE_INVERTED

kconfig does not actually set CONFIG_LV_DISPLAY_ORIENTATION_LANDSCAPE or CONFIG_LV_DISPLAY_ORIENTATION_LANDSCAPE_INVERTED, it sets CONFIG_DISPLAY_ORIENTATION_LANDSCAPE and CONFIG_DISPLAY_ORIENTATION_LANDSCAPE_INVERTED

End result is that I get an invalid orientation error regardless of which orientation I set. I think this is just a simple kconfig update to fix, adding the LV prefix?

for now I've fixed it in my own stuff by picking the previous commit for the submodule in my project, but since lvgl/lv_port_esp32 is using 9fed1cc as its referenced commit, it'll be broken for that repo/demo :(

[C47D]

Hi,
Thanks for the report, I have been really busy with day work, but will fix it and update the demo project.

EDIT
Could you please test this 0442ebe

[neggles]

Hi, sorry, I thought I'd replied to this already... Yes, that's exactly what I did in my fork to fix it (revert of previous commit that changed those two lines). Works fine with that change 😄