Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Detection #247

Closed
Luxonis-Brandon opened this issue Oct 20, 2020 · 15 comments
Closed

Edge Detection #247

Luxonis-Brandon opened this issue Oct 20, 2020 · 15 comments
Labels
enhancement New feature or request

Comments

@Luxonis-Brandon
Copy link
Contributor

Start with the why:

Edge detection is a useful building block in many CV/AI pipelines and the DepthAI hardware has hardware acceleration for this feature.

Move to the how:

Implement the edge detection hardware acceleration as a node in the Gen2 pipeline builder (#136).

Move to the what:

Support hardware-accelerated edge detection as a pipeline node.

@Luxonis-Brandon Luxonis-Brandon added enhancement New feature or request Gen2 labels Oct 20, 2020
@matanox
Copy link

matanox commented Apr 8, 2021

I have seen this feature mentioned now on the store. So is it really in yet?

It says there:

image

@Luxonis-Brandon
Copy link
Contributor Author

Hi @matanster ,

Sorry about these not being implemented yet. We planned to have these out in December, but have been behind.

This is among 10 features we planned to release in December in conjunction with our bulk shipment of devices, but have not been finished yet.

For these 10 not-yet-started features, and also then others that are in-progress and finished, see here:
https://github.com/orgs/luxonis/projects/2

Anyway, we're more than happy to issue a full refund on the device here if you would like. I'm not immediately sure on the timing to get these out. Right now we're heads-down on fixing a subpixel crash (luxonis/depthai-python#147) that can occur in some cases and getting full-rate IMU support out (in addition to Gen2 calibration improvements, and scripting capability #207 (comment)).

Thoughts?

Sorry about this not being out yet.

-Brandon

@Luxonis-Brandon
Copy link
Contributor Author

(Accidentally hit the close button, just reopened.)

@matanox
Copy link

matanox commented Apr 9, 2021

All cool.

@Luxonis-Brandon
Copy link
Contributor Author

Hi @matanster ,

So these are always famous last words, but I think we should be able to have both of these at least initially released this month, if all goes well:

  • Edge Detector (Canny Filter, specifically).
  • Harris Filter (Corner detector).

Thoughts?

Thanks,
Brandon

@matanox
Copy link

matanox commented Apr 10, 2021

I would by no means re-prioritize the workflow just due to one Github question ;-)

@dhruvmsheth
Copy link
Contributor

Hi @matanster @Luxonis-Brandon I published an unofficial example of Edge Detection using Harris filtering today, so you can try it out -
https://github.com/dhruvsheth-ai/gen2-api-depth-experiments/tree/main/edge-harris

I'll be adding a demo for canny edge detection too, this week.

Also, in case you face any issue, you can open an issue on the repo or here.

Thanks!

@Luxonis-Brandon
Copy link
Contributor Author

I would by no means re-prioritize the workflow just due to one Github question ;-)

Sounds good. Actually we ran into an issue with the latest Raspberry Pi OS that we need to debug (#354). So will jump on that first.

And thanks @dhruvsheth-ai !

@Luxonis-Brandon
Copy link
Contributor Author

We're still working on this as a firmware module, but in the meantime Kunal implemented this as a node that runs on DepthAI here, using the technique from here.

image

@Luxonis-Brandon
Copy link
Contributor Author

First version of the hardware block in DepthAI being used is below:

DepthAI Edge Filter

@eric-schleicher
Copy link

melike!

@eric-schleicher
Copy link

note: deadlink. is this example published?

Hi @matanster @Luxonis-Brandon I published an unofficial example of Edge Detection using Harris filtering today, so you can try it out -
https://github.com/dhruvsheth-ai/gen2-api-depth-experiments/tree/main/edge-harris

I'll be adding a demo for canny edge detection too, this week.

Also, in case you face any issue, you can open an issue on the repo or here.

Thanks!

@Luxonis-Brandon
Copy link
Contributor Author

Those ones were host-side versions of those; not running on DepthAI.

The example Szabi made is using a hardware bock in DepthAI. And this one is using the OpenVINO technique to run on DepthAI, using the SHAVES probably.

@dhruvmsheth
Copy link
Contributor

note: deadlink. is this example published?

Hi @matanster @Luxonis-Brandon I published an unofficial example of Edge Detection using Harris filtering today, so you can try it out -
https://github.com/dhruvsheth-ai/gen2-api-depth-experiments/tree/main/edge-harris
I'll be adding a demo for canny edge detection too, this week.
Also, in case you face any issue, you can open an issue on the repo or here.
Thanks!

Sorry for the trouble @eric-schleicher . Thanks for the PR. Since I migrated the example to a different folder, the link might have gone broken.

@dhruvmsheth
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants