Skip to content

Commit d546be4

Browse files
committed
LUTECE-2206 : avoid open redirect
1 parent 56b7b60 commit d546be4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/java/fr/paris/lutece/portal/web/style/ThemesJspBean.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import fr.paris.lutece.portal.service.portal.ThemesService;
4141
import fr.paris.lutece.portal.service.template.AppTemplateService;
4242
import fr.paris.lutece.portal.service.util.AppPathService;
43+
import fr.paris.lutece.portal.service.util.AppPropertiesService;
4344
import fr.paris.lutece.portal.web.admin.AdminFeaturesPageJspBean;
4445
import fr.paris.lutece.portal.web.constants.Messages;
4546
import fr.paris.lutece.util.html.HtmlTemplate;
@@ -138,7 +139,8 @@ public String doModifyUserTheme( HttpServletRequest request, HttpServletResponse
138139
String strTheme = request.getParameter( PARAMETER_THEME );
139140
String strForwardUrl = request.getParameter( PARAMETER_URL );
140141

141-
if ( !SecurityUtil.containsCleanParameters( request ) )
142+
if ( !SecurityUtil.containsCleanParameters( request )
143+
|| !SecurityUtil.isInternalRedirectUrlSafe( strForwardUrl, request ) )
142144
{
143145
return AppPathService.getBaseUrl( request );
144146
}

0 commit comments

Comments
 (0)