Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsDropDownMenu not removed from body when destroyed #183

Closed
REBELinBLUE opened this issue Jul 27, 2018 · 1 comment
Closed

vsDropDownMenu not removed from body when destroyed #183

REBELinBLUE opened this issue Jul 27, 2018 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@REBELinBLUE
Copy link

REBELinBLUE commented Jul 27, 2018

When the vsDropDownMenu is mounted you insert the real dropdown as the first child of the body, but when the vsDropDownMenu is destroyed it isn't removed, that means as you navigate around a SPA you can end up with lots of them dropdowns in the document

I solved this with

https://github.com/REBELinBLUE/pomodoro/blob/master/src/components/Settings/Dropdown.vue#L42

but obviously it isn't the best way as the component should clean up after itself

@luisDanielRoviraContreras luisDanielRoviraContreras added bug Something isn't working enhancement New feature or request labels Jul 27, 2018
@luisDanielRoviraContreras
Copy link
Member

The error was corrected in the latest version, thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants