Skip access method when lambda body method can be promoted. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,4 +37,12 @@ public static boolean isPlatformFactoryMethod(int access, String name, String de | |||
| && desc.equals(targetDesc) | |||
| && Flags.hasFlag(access, ACC_PRIVATE | ACC_STATIC); | |||
| } | |||
|
|
|||
| public static boolean isBodyMethodName(String name) { | |||
| return name.startsWith("lambda\\$"); | |||
There was a problem hiding this comment.
javac format is "lambda$methodname$number" and ECJ is "lambda$number". I don't think this is ideal, but the name is highly unlikely to change without a major version bump in the JDK which could just as well bring classfile changes that break everything else about this tool.
JakeWharton
force-pushed
the
jw/skip-accessors-and-promote-body-methods
branch
from
c0d2e45
to
5d5a87c
Compare
JakeWharton
force-pushed
the
jw/skip-accessors-and-promote-body-methods
branch
from
5d5a87c
to
bf93245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #81 point 2.