Added retrolambda.javaHacks configuration option #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
javac
may produce incorrect but executable byte code that cannot be translated with ASM therefore making class downgrade impossible. This pull request enables:-Dretrolambda.javacHacks
support for the tool<javaHacks>
support for the Maven pluginI could downgrade the code using a patched 2.5.5-SNAPSHOT version and the downgraded code seems to work correctly. The option name
javaHacks
is a possible subject to change or rename. For example, enabling the key will allow to downgrade the following code that cannot be processed with Retrolambda 2.5.4:As of Retrolambda 2.5.4 the code above fails with even for the latest JDK 1.8
javac
(1.8.0_181):Please note that JDK 1.8 may be a must, for example when using tools like Checker Framework. Please see https://gitlab.ow2.org/asm/asm/issues/317845 for more details.