Handle subdomains

[iamlasse]

I am trying to figure out if the package can handle subdomains and nested domains? An older version I modified to handle deeper/nested layers, but the code in 1.2 is drastically changed since that version so my code won't work anymore.

[jaspertey]

What are your exact use cases? I have tried to keep subdomain support working throughout the versions:

https://github.com/lunarstorm/laravel-ddd?tab=readme-ov-file#subdomains-nested-domains

Subdomains can be specified with dot notation wherever a domain option is accepted.

# Domain/Reporting/Internal/ViewModels/MonthlyInvoicesReportViewModel
php artisan ddd:view-model Reporting.Internal:MonthlyInvoicesReportViewModel

# Domain/Reporting/Customer/ViewModels/MonthlyInvoicesReportViewModel
php artisan ddd:view-model Reporting.Customer:MonthlyInvoicesReportViewModel

# (supported by all commands where a domain option is accepted)

[iamlasse]

So I consider the V1 to be not part of the "domain" but a versioning. So domain would be Betterflow and subdomain is Editorials.

[iamlasse]

$subdomain = str($subdomain)->trim('\/')->replace('.', '\')->toString();
This was the one change I did that allows me to add any level of nesting depth and also works with the Betterflow.V1.Editorials:Something/SomethingElse/NameOfThing

INFO Model [app/Domains/Betterflow/V1/Editorials/Models/Something/SomethingElse/NameOfThing.php] created successfully.

[jaspertey]

I will take a look at this and work on an official patch soon.

Keep in mind that in the eyes of this package, there is no awareness of versioning, and therefore the subdomain would be internally recognized as "V1/Editorials". And this will be okay for your needs, since everything gets generated into the desired location.

[iamlasse]

Right sorry for late response. So the fix i added , i didn't do a pr as i didn't know if it would maybe break other things. The "domains" should in my use case be able to be potentially unlimited, so a App\Domains\Betterflow\V1\Editorials\Assets\Models Asset.php would be supported. Without my fix, the path would stop at V1.Editorials.Assets and that would be the folder name. Also the path in the namespace would be with a dot breaking the code. I can show you what i did to change it perhaps you have a better solution?

[jaspertey]

Right sorry for late response. So the fix i added , i didn't do a pr as i didn't know if it would maybe break other things. The "domains" should in my use case be able to be potentially unlimited, so a App\Domains\Betterflow\V1\Editorials\Assets\Models Asset.php would be supported. Without my fix, the path would stop at V1.Editorials.Assets and that would be the folder name. Also the path in the namespace would be with a dot breaking the code. I can show you what i did to change it perhaps you have a better solution?

Sorry, I should've commented - I closed this because it was patched in 1.2.1, see #86

[iamlasse]

Yes nice, thank you for letting me know this does indeed fix my use case. I see you used my namespacing in the tests :)