Skip to content

Conversation

@myedibleenso
Copy link
Member

This PR simplifies the pagination process by using a Lucene doc ID, rather than an OdinsonScoreDoc.

No need to use an OdinsonScoreDoc when a Doc ID will suffice
@myedibleenso
Copy link
Member Author

It looks like we don't have real tests in place for pagination. We need to add at least a few (ex. n = 1, after = 1, n = 1, after = 3, n = 2, after = 1, etc).

@myedibleenso
Copy link
Member Author

@marcovzla @danebell

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #371 (c222232) into master (c160833) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   75.04%   74.99%   -0.06%     
==========================================
  Files          93       93              
  Lines        4052     4051       -1     
  Branches      308      311       +3     
==========================================
- Hits         3041     3038       -3     
- Misses       1011     1013       +2     
Impacted Files Coverage Δ
...odinson/lucene/index/OdinsonCollectorManager.scala 100.00% <ø> (ø)
...ala/ai/lum/odinson/lucene/index/OdinsonIndex.scala 100.00% <ø> (ø)
...i/lum/odinson/lucene/search/OdinsonCollector.scala 50.94% <ø> (-2.63%) ⬇️
...m/odinson/lucene/search/OdinsonIndexSearcher.scala 10.00% <0.00%> (ø)
...ra/src/main/scala/ai/lum/odinson/extra/Shell.scala 0.00% <0.00%> (ø)
...rc/main/scala/ai/lum/odinson/ExtractorEngine.scala 75.31% <75.00%> (+0.47%) ⬆️
...odinson/lucene/index/IncrementalOdinsonIndex.scala 82.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c160833...c222232. Read the comment docs.

@myedibleenso myedibleenso force-pushed the master branch 6 times, most recently from 611d79b to 1b8a2ca Compare July 5, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant