Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mousewheel during scrolling #405

Open
Alessiosdm opened this issue Sep 7, 2020 · 18 comments
Open

Disable mousewheel during scrolling #405

Alessiosdm opened this issue Sep 7, 2020 · 18 comments

Comments

@Alessiosdm
Copy link

Hi,
Would it be possible to disable the continuous mousewheel during scrolling?
Also on the official demo I notice a shaking if you try to move the wheel more than once. (Chrome on Mac and Win)
Thank you

@Alessiosdm
Copy link
Author

To update.
I just added e.preventDefault();
after line 270:
wheelHandler: function (e) {
// added
e.preventDefault();
...
...
Now the shaking is gone ;)

@lukehaas
Copy link
Owner

lukehaas commented Sep 7, 2020

@Alessiosdm does adding that not cause problems with scrolling sections that are taller than the viewport?

@Alessiosdm
Copy link
Author

Hi Lukehaas,
Exactly the problem I just encountered !!!
I would also have some fancyboxes with scrolls and these no longer have mousewheels.
I just don't know how to fix it right now.
Could there be another way?

Thanks
Ale

@cherjr
Copy link

cherjr commented Nov 20, 2020

same problem here! any news, or, maybe, workaround?..

@Alessiosdm
Copy link
Author

same problem here! any news, or, maybe, workaround?..

Hi,
I unfortunately have not found any solution to the flickering during scrolling... :(
Ciao ciao

@cherjr
Copy link

cherjr commented Nov 20, 2020

Well, it looks like someone does: https://s8.capital/ ...

@lukehaas
Copy link
Owner

@Alessiosdm I noticed the Scrollify demo site was using an old version of Scrollify, I've now updated it to the latest version. Could you tell me if you are still seeing the same issue there? (make sure to do a hard refresh)

@Alessiosdm
Copy link
Author

Great Luke!!!!!
Now much better.
Do you confirm that Version 1.0.21 is ok?
Thanks 1000

@lukehaas
Copy link
Owner

Thanks, yes, please upgrade to 1.0.21 👍

@cherjr
Copy link

cherjr commented Nov 20, 2020

Thanks, yes, please upgrade to 1.0.21 👍

unfortunately, that didn't solve the problem for me - I guess, there's still this problem with scrolling sections that are taller than the viewport (?). I can still see it on https://projects.lukehaas.me/scrollify/#options (Chrome/Win10): if you make continuous mouse-wheel action without waiting for the effect to stop - the problem presents itself. Do you see it?... it's very difficult to make a video, it's very fast.

@Alessiosdm
Copy link
Author

Sorry, I didn't notice ...
I confirm that the flickering occurs when switching from a long section to a full Height one. (Win & Mac)

@salinap
Copy link

salinap commented Nov 20, 2020

Same problem

@cherjr
Copy link

cherjr commented Nov 22, 2020

@lukehaas any chance for us?...

@salinap
Copy link

salinap commented Dec 17, 2020

@Alessiosdm another solution https://jsfiddle.net/s0c3rhLk/1/

@najeeboffice
Copy link

@Alessiosdm another solution https://jsfiddle.net/s0c3rhLk/1/

not working as expected. it has same issue some times other sections overlap.

@najeeboffice
Copy link

Please someone help him fix this flikering issue. I tried many scroll snap plugin and this one works very easily but only issue is scroll flikering.

@miqueiasantos
Copy link

I added the e.preventDefault() inside the if (locked) and it worked for me:

if (locked) {
    e.preventDefault();
    return false;
}

@imamuddinkhan
Copy link

e.preventDefault();

but on mobile devices this code not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants