Merge pull request #112 from lukasgit/staging

Sync staging 0_4_6 with master

Author: lukasgit

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.4.6] - April 29, 2020
+
+* Fixed openExistingContact in Android and in example (@engylemure)
+
 ## [0.4.5] - April 26, 2020
 
 * Fixed crashing where activity result coming back from another plugin and not handled (@lidongze91)

README.md

@@ -12,7 +12,7 @@ To use this plugin, add `contacts_service` as a [dependency in your `pubspec.yam
 For example:  
 ```yaml  
 dependencies:  
-    contacts_service: ^0.4.5
+    contacts_service: ^0.4.6
 ```  
   
 ## Permissions  

android/src/main/java/flutter/plugins/contactsservice/contactsservice/ContactsServicePlugin.java

@@ -132,7 +132,7 @@ public void onMethodCall(MethodCall call, Result result) {
         }
         break;
       } case "openExistingContact" :{
-        final Contact contact = Contact.fromMap((HashMap)call.arguments);
+        final Contact contact = Contact.fromMap((HashMap)call.argument("contact"));
         if (delegate != null) {
           delegate.setResult(result);
           delegate.openExistingContact(contact);
@@ -297,6 +297,7 @@ void openExistingContact(Contact contact) {
           finishWithResult(FORM_COULD_NOT_BE_OPEN);
         }
       } catch(Exception e) {
+        finishWithResult(FORM_COULD_NOT_BE_OPEN);
       }
     }
 

example/lib/contacts_list_page.dart

@@ -134,7 +134,6 @@ class ContactDetailsPage extends StatelessWidget {
     try {
       var contact = await ContactsService.openExistingContact(_contact,
           iOSLocalizedLabels: iOSLocalizedLabels);
-      print(contact.emails.first.label);
       if (onContactDeviceSave != null) {
         onContactDeviceSave(contact);
       }

pubspec.yaml

@@ -1,6 +1,6 @@
 name: contacts_service
 description: A Flutter plugin to retrieve and manage contacts on Android and iOS devices.
-version: 0.4.5
+version: 0.4.6
 authors:
 - Lukas Dickie <lukas@changefly.com>
 - Clovis Nicolas <clovisnicolas0@gmail.com>