Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.40.0 #71

Closed
joncursi opened this issue Jan 9, 2017 · 5 comments
Closed

Upgrade to React Native 0.40.0 #71

joncursi opened this issue Jan 9, 2017 · 5 comments

Comments

@joncursi
Copy link

joncursi commented Jan 9, 2017

I noticed that in ios/ReactNativeConfig/ReactNativeConfig.h, a header change might be needed to support RN 0.40.0:

#import <React/RCTBridgeModule.h>
@ujwal-setlur
Copy link

Will there be a release with this change?

@ujwal-setlur
Copy link

I see version 0.2.2 was released to handle react-native 0.40. I believe the version major number should have been bumped. Now all projects < RN 0.4.0 will break that have a dependency declared as:

"react-native-config": "^0.2.1"

We will now have to pin the version number to 0.2.1

"react-native-config": "0.2.1"

But really, the major number should have been bumped per facebook guidelines:

@darrenchiu
Copy link

same as @ujwal-setlur , upgrading to 0.2.2 caused my RN 0.39 project to break. It would be great if we can indicate this breaking change by major version number. +1

@GantMan
Copy link
Collaborator

GantMan commented Feb 1, 2017

correct, - this is a big issue with lots of these.

unpublish is not working at the moment, so the key is to publish 0.3.0and then rollback to a previous commit to publish 0.2.3

I'd be happy to help @pedro if you'd like. But I'll need npmjs access.

@pedro
Copy link
Contributor

pedro commented Feb 1, 2017

Oops! Sorry for the trouble folks, I just released 0.2.5 (compat with previous rn) and moved these changes to 0.3 per @GantMan's comment above (it's actually 0.3.1 😬 released 0.3.0 by accident but it should work too).

Will be more careful to not break this in future releases.

@GantMan you have npm access now!

@pedro pedro closed this as completed Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants