-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React Native 0.40.0 #71
Comments
Will there be a release with this change? |
I see version 0.2.2 was released to handle react-native 0.40. I believe the version major number should have been bumped. Now all projects < RN 0.4.0 will break that have a dependency declared as:
We will now have to pin the version number to 0.2.1
But really, the major number should have been bumped per facebook guidelines: |
same as @ujwal-setlur , upgrading to 0.2.2 caused my RN 0.39 project to break. It would be great if we can indicate this breaking change by major version number. +1 |
correct, - this is a big issue with lots of these. unpublish is not working at the moment, so the key is to publish I'd be happy to help @pedro if you'd like. But I'll need npmjs access. |
Oops! Sorry for the trouble folks, I just released 0.2.5 (compat with previous rn) and moved these changes to 0.3 per @GantMan's comment above (it's actually 0.3.1 😬 released 0.3.0 by accident but it should work too). Will be more careful to not break this in future releases. @GantMan you have npm access now! |
I noticed that in
ios/ReactNativeConfig/ReactNativeConfig.h
, a header change might be needed to support RN 0.40.0:The text was updated successfully, but these errors were encountered: