This repository was archived by the owner on May 16, 2024. It is now read-only.
fix telescope issue when no matches #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there were no matches in the telescope search and the user pressed enter, we had a crash
It was for caching, but now it became useless because the buffer previewer will override it so removing it is fine. But it's clearly an issue with telescope. |
|
otherwise the "if selection" thing is in nvim-devdocs for sure. |
|
oh my bad, I've edited your comment instead of quote reply... |
|
yes, but i think the keep_last_buf was also part of it. well possibly first the if selection, and then second crash (taking down the whole neovim) after closing the telescope window after the first crash, related to keep_last_buf. maybe fixing the if selection was enough though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there were no matches in the telescope search and the user pressed enter, we had a crash.
honestly i'm not sure what keep_last_buf is supposed to do...
you can reproduce the crash by opening the telescope picker, then typing garbage in it, until there are no matches, then pressing enter. This fixes it. Not sure whether commenting keep_last_buf would cause some loss of feature..?