-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lucid 2.x #44
base: main
Are you sure you want to change the base?
Feat/lucid 2.x #44
Conversation
- standardise files (type hints, return types, remove docblocks) - correctly typehint entities - remove unused code and files - fix str_replace warning
- remove tests files in delete commands - add missing delete calls to test-commands.sh
- format strings - remove unused code - fix return types
- Added and run laravel pint - Added Laravel stan, configured it for level 5 and solved all issues - Rewrite commands to extend Laravel command instead of Symfony command
Hi ksimenic, |
@ntgraph sorry man. I completely lost will to do any contributions since this was ignored for such a long time. There is obviously no incentive from authors end to continue contributions so I consider this project abandoned. It is a real pity though, lucid architecture is one of the best architectures I came across in my 10 years of development. If you need any custom work, I will be more than happy to chat! |
Hi, |
I've tried to reach out to @Mulkave through twitter as well, but had little succes. I wonder if he would be open to others participating in this project to keep it going. In that way there would be a stable basis for the project. I would be able to assist in that matter as well; we use it heavily in a few big projects as well. Have switched over to your fork for now; but would really like to get this project 'officially' supported again. Have been a fan since the original presentation on Laracon in Amsterdam :-) |
Can you try in LinkedIn? |
This PR doesn't add anything new to lucid. Main purpose of opening this PR is to set standards for future development efforts. Initially it started as a potential solution to #36, but I soon realised that such fixes aren't meant to be backward compatible and won't be maintainable long term.
As a result, I decided to drop support for anything below Laravel 9.x and PHP 8.x. Since new codebase won't work with older PHP versions - mainly because of typehints and return types - my suggestion is to start new version 2.x and (slowly) stop supporting old version.
In the scope of this PR, following changes were done:
Planned future upgrade and standardisation efforts are:
as well as actively contributing to solving other reported issues.