Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hot corner #24

Closed
ld-web opened this issue Oct 31, 2023 · 8 comments
Closed

Add support for hot corner #24

ld-web opened this issue Oct 31, 2023 · 8 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ld-web
Copy link

ld-web commented Oct 31, 2023

When reaching for hot corner (usually top left corner) to display all windows and then click on one to switch, it suddenly scrolls after switching, as it was with Alt + Tab or other switching methods.

@lbltavares already suggested a solution (thanks, it was quick !), which has to be tested before opening a PR. It's for Gnome 45 (maybe we can add a "Gnome 45" label to the issue ?) :

import * as Overview from "resource:///org/gnome/shell/ui/overview.js";
...
this._injectionManager.overrideMethod(
    Overview.Overview.prototype,
    '_showDone',
    (originalMethod) => {
        return function (...args) {
            movePointer();
            originalMethod.call(this, ...args);
        };
    }
);
@lucasresck lucasresck self-assigned this Oct 31, 2023
@lucasresck lucasresck added bug Something isn't working enhancement New feature or request labels Oct 31, 2023
@lucasresck
Copy link
Owner

Thank you, @ld-web, for this issue. It is indeed a great improvement to the extension. This can be solved before releasing v5 (GNOME 45) and it can be added to v4 (GNOME <= 44) too. I intend to work on this soon, but feel free to also work on this. Thank you again!

@lucasresck lucasresck changed the title Add support for hot corner (Gnome 45) Add support for hot corner Oct 31, 2023
@lucasresck
Copy link
Owner

My suggestion is including this change in a new pull request to develop after merging #21. Then, after, creating another pull request to gjs-legacy-develop to add support to the previous version.

@lucasresck
Copy link
Owner

I've just created a PR: #25. I'll use the extension for some days before merging it, but it has been working so far.

Thank you, @ld-web and @lbltavares, for noticing this and coming up with a solution.

@ld-web
Copy link
Author

ld-web commented Nov 6, 2023

Thank you @lucasresck, I will pull it and test it locally as well, and then give you feedback !

@lucasresck
Copy link
Owner

I've already merged #25. I'll still leave this issue open so that it can be approached for GNOME <= 44. Thanks everyone for all help!

@lucasresck
Copy link
Owner

In fact, it's better to open a new issue to work on this for GNOME <= 44.

@ld-web
Copy link
Author

ld-web commented Nov 18, 2023

Sorry for the delay, everything looks good to me on v5, thanks !

@lucasresck
Copy link
Owner

Thank you for your feedback, @ld-web.

Just to update you, extension's v5 went for review on GNOME Extensions but it was rejected: #28. I still need to work on this before releasing the update on GNOME Extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants