This repository was archived by the owner on Mar 26, 2023. It is now read-only.
Removes dead connections #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu4p
suggested changes
Jul 23, 2021
Comment on lines
+88
to
+90
| for { | ||
| select { | ||
| case <-timer.C: |
Owner
There was a problem hiding this comment.
You can just do for range timer.C instead
| @@ -1,2 +0,0 @@ | |||
| #!/bin/bash | |||
| @@ -1,3 +0,0 @@ | |||
| #!/bin/bash | |||
| loadData() | ||
|
|
||
| // Spawn timer to clean dead connections every 5 mins | ||
| timer := time.NewTicker(5 * time.Minute) |
Owner
There was a problem hiding this comment.
I think every 5 minutes might be overly conservative
Comment on lines
+139
to
+143
| for i, c := range activeClients { | ||
| if c.Hostname == ac.Hostname { | ||
| activeClients = append(activeClients[:i], activeClients[i+1:]...) | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
I think this might introduce a bug where for whatever reason 2 client instances run on the same machine, this should therefore also check if the old session still works and keep it in that case.
lu4p
reviewed
Jul 23, 2021
| for i, _ := range activeClients { | ||
| ac := getClient(i) | ||
| if err := ac.getHostname(); err != nil { | ||
| activeClients = append(activeClients[:i], activeClients[i+1:]...) |
Owner
There was a problem hiding this comment.
Add a notification that a client disconnected
[-] Client %name disconnected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not tested this fully but it compiles correctly. When I have time I will test
Fixes Issue #247