From eea13027bc999b1f04fcc18dcb71dcd28e8b4791 Mon Sep 17 00:00:00 2001
From: Eman Ali <eali@swin.edu.au>
Date: Thu, 1 Feb 2024 09:02:24 +1100
Subject: [PATCH] wrap the SkyModePre code in a function and call in scheduler
 class rather than globally as per Eric's comment

---
 .../scheduler_dashboard.py                    | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/schedview/app/scheduler_dashboard/scheduler_dashboard.py b/schedview/app/scheduler_dashboard/scheduler_dashboard.py
index 26fee96b..22405c90 100644
--- a/schedview/app/scheduler_dashboard/scheduler_dashboard.py
+++ b/schedview/app/scheduler_dashboard/scheduler_dashboard.py
@@ -88,14 +88,13 @@
 }
 """
 
-# Load available datetime range from SkyBrightness_Pre files
-sky_model = SkyModelPre()
-MIN_DATE = Time(sky_model.mjd_left.min(), format="mjd")
-MAX_DATE = Time(sky_model.mjd_right.max(), format="mjd")
-DATE_BOUNDS = (
-    MIN_DATE.to_datetime(),
-    MAX_DATE.to_datetime(),
-)
+
+def get_sky_brightness_date_bounds():
+    """Load available datetime range from SkyBrightness_Pre files"""
+    sky_model = SkyModelPre()
+    min_date = Time(sky_model.mjd_left.min(), format="mjd").to_datetime()
+    max_date = Time(sky_model.mjd_right.max(), format="mjd").to_datetime()
+    return (min_date, max_date)
 
 
 def url_formatter(dataframe_row, name_column, url_column):
@@ -131,6 +130,9 @@ class Scheduler(param.Parameterized):
     rubin_scheduler.scheduler.schedulers.CoreScheduler, and conditions is an
     instance of rubin_scheduler.scheduler.conditions.Conditions.
     """
+
+    _date_bounds = get_sky_brightness_date_bounds()
+
     scheduler_fname = param.String(
         default="",
         label="Scheduler pickle file",
@@ -139,8 +141,8 @@ class Scheduler(param.Parameterized):
     widget_datetime = param.Date(
         default=DEFAULT_CURRENT_TIME.datetime.date(),
         label="Date and time (UTC)",
-        doc=f"Select dates between {MIN_DATE.iso} and {MAX_DATE.iso}",
-        bounds=DATE_BOUNDS,
+        doc=f"Select dates between {_date_bounds[0]} and {_date_bounds[1]}",
+        bounds=_date_bounds,
     )
     url_mjd = param.Number(default=None)
     widget_tier = param.Selector(