refactor: rename rule (#5)

Author: lsndr

src/configs/recommended.ts

@@ -14,6 +14,6 @@ export const name = 'recommended';
 export const config = {
   plugins: [pluginName],
   rules: {
-    [`${pluginName}/no-inheritance`]: 'error',
+    [`${pluginName}/no-class-inheritance`]: 'error',
   },
 };

src/rules/index.ts

@@ -1,5 +1,5 @@
-import * as noInheritanceRule from './no-inheritance';
+import * as noClassInheritanceRule from './no-class-inheritance';
 
 export const rules = {
-  [noInheritanceRule.name]: noInheritanceRule.rule,
+  [noClassInheritanceRule.name]: noClassInheritanceRule.rule,
 };

src/rules/no-inheritance/class-type.ts renamed to src/rules/no-class-inheritance/class-type.ts

@@ -0,0 +1,2 @@
+export * from './class-type';
+export * from './no-class-inheritance';

src/rules/no-class-inheritance/index.ts

@@ -1,5 +1,5 @@
 import { RuleTester } from '@typescript-eslint/rule-tester';
-import * as noInheritanceRule from './no-inheritance.rule';
+import * as noInheritanceRule from './no-class-inheritance';
 import * as path from 'path';
 
 describe('Rule', () => {
@@ -29,7 +29,7 @@ describe('Rule', () => {
       },
       {
         code: 'abstract class Parent {} class Child extends Parent {}',
-        errors: [{ messageId: 'inheritanceNotAllowed' }],
+        errors: [{ messageId: 'inheritanceOfAbstractClassesNotAllowed' }],
         options: [{ noInheritanceOfAbstractClasses: true }],
       },
       {

src/rules/no-inheritance/no-inheritance.rule.spec.ts renamed to src/rules/no-class-inheritance/no-class-inheritance.spec.ts

@@ -9,7 +9,7 @@ const createRule = ESLintUtils.RuleCreator(
 /**
  * Rule name
  */
-export const name = 'no-inheritance';
+export const name = 'no-class-inheritance';
 
 /**
  * Options
@@ -36,9 +36,12 @@ const meta: NamedCreateRuleMeta<string, Options> = {
     description: 'Inheritance is not allowed.',
   },
   messages: {
-    inheritanceNotAllowed: 'Inheritance is not allowed.',
+    inheritanceNotAllowed:
+      'Inheritance of non-abstract classes is not allowed. Consider using composition or extend abstract class',
+    inheritanceOfAbstractClassesNotAllowed: 'Inheritance is not allowed',
   },
-  type: 'problem',
+  hasSuggestions: true,
+  type: 'suggestion',
   schema: [
     {
       type: 'object',
@@ -72,13 +75,15 @@ export const rule = createRule({
           return;
         }
 
-        if (
-          options[0]?.noInheritanceOfAbstractClasses ||
-          !classType.inheritsOnlyAbstractClasses()
-        ) {
+        if (options[0]?.noInheritanceOfAbstractClasses) {
+          context.report({
+            messageId: 'inheritanceOfAbstractClassesNotAllowed',
+            loc: node.loc,
+          });
+        } else if (!classType.inheritsOnlyAbstractClasses()) {
           context.report({
             messageId: 'inheritanceNotAllowed',
-            node,
+            loc: node.loc,
           });
         }
       },