Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix Dockerfile syntax - unify AS casing and use ENV key=value format #10459

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+7 −7
Open

Development: Fix Dockerfile syntax - unify AS casing and use ENV key=value format #10459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c1003
fix: unify casing for 'AS' keyword in FROM instruction
egekocabas Mar 10, 2025
3e44eb8
fix: use modern ENV key=value format instead of legacy syntax
egekocabas Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docker/artemis/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ARG WAR_FILE_STAGE="builder"
#-----------------------------------------------------------------------------------------------------------------------
# build stage
#-----------------------------------------------------------------------------------------------------------------------
FROM --platform=$BUILDPLATFORM docker.io/library/eclipse-temurin:21-jdk as builder
FROM --platform=$BUILDPLATFORM docker.io/library/eclipse-temurin:21-jdk AS builder

# some Apple M1 (arm64) builds need python3 and build-essential(make+gcc) for node-gyp to not fail
RUN echo "Installing build dependencies" \
Expand Down Expand Up @@ -66,7 +66,7 @@ RUN \
#-----------------------------------------------------------------------------------------------------------------------
# external build stage
#-----------------------------------------------------------------------------------------------------------------------
FROM docker.io/library/alpine:3 as external_builder
FROM docker.io/library/alpine:3 AS external_builder

#default path of the built .war files
ARG WAR_FILE_PATH="/opt/artemis/build/libs"
Expand All @@ -78,12 +78,12 @@ COPY ./build/libs/*.war Artemis.war
#-----------------------------------------------------------------------------------------------------------------------
# war file stage (decides whether an external .war file will be used or the Docker built .war file)
#-----------------------------------------------------------------------------------------------------------------------
FROM ${WAR_FILE_STAGE} as war_file
FROM ${WAR_FILE_STAGE} AS war_file

#-----------------------------------------------------------------------------------------------------------------------
# runtime stage
#-----------------------------------------------------------------------------------------------------------------------
FROM docker.io/library/eclipse-temurin:21-jdk as runtime
FROM docker.io/library/eclipse-temurin:21-jdk AS runtime

#default path of the built .war files
ARG WAR_FILE_PATH="/opt/artemis/build/libs"
Expand All @@ -103,9 +103,9 @@ RUN \
echo "Fixing locales" \
&& sed -i -e 's/# en_US.UTF-8 UTF-8/en_US.UTF-8 UTF-8/' /etc/locale.gen \
&& locale-gen
ENV LC_ALL en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US.UTF-8
ENV LC_ALL=en_US.UTF-8
ENV LANG=en_US.UTF-8
ENV LANGUAGE=en_US.UTF-8

# Create directories for volumes, create artemis user and set right owners
RUN \
Expand Down
Loading