Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Add learner profile interface #10440base: develop
Are you sure you want to change the base?
Adaptive learning
: Add learner profile interface #10440Changes from all commits
aeb7c34
3b83402
b584591
30a1605
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are min and max profile values? Can they be named in a more descriptive way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no await here, then you can also remove the async
Check notice on line 20 in src/main/webapp/app/shared/editable-slider/double-slider.component.scss
src/main/webapp/app/shared/editable-slider/double-slider.component.scss#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codacy
Check notice on line 23 in src/main/webapp/app/shared/editable-slider/double-slider.component.scss
src/main/webapp/app/shared/editable-slider/double-slider.component.scss#L23
Check notice on line 26 in src/main/webapp/app/shared/editable-slider/double-slider.component.scss
src/main/webapp/app/shared/editable-slider/double-slider.component.scss#L26
Check notice on line 33 in src/main/webapp/app/shared/editable-slider/double-slider.component.scss
src/main/webapp/app/shared/editable-slider/double-slider.component.scss#L33