-
-
Notifications
You must be signed in to change notification settings - Fork 23
breaking: bubbletea/lipgloss/bubbles v2 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- ref: #50 Signed-off-by: Liam Stanley <liam@liam.sh>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 94.07% 93.19% -0.89%
==========================================
Files 5 5
Lines 270 235 -35
==========================================
- Hits 254 219 -35
Misses 15 15
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Liam Stanley <liam@liam.sh>
Signed-off-by: Liam Stanley <liam@liam.sh>
|
Hey @lrstanley, just want to drop this in and let you know that we're using this branch and patches in Soft Serve v2 https://github.com/aymanbagabas/bubblezone/tree/v2-exp. Please let me know if you have any comments or concerns 🙂 |
Signed-off-by: Liam Stanley <liam@liam.sh>
Signed-off-by: Liam Stanley <liam@liam.sh>
…ound color message Signed-off-by: Liam Stanley <liam@liam.sh>
* chore: bump dependencies to charm.land modules * fix: update examples and tests with new bubbletea v2 logic Signed-off-by: Liam Stanley <liam@liam.sh> * feat: update readme for v2 Signed-off-by: Liam Stanley <liam@liam.sh> --------- Signed-off-by: Liam Stanley <liam@liam.sh> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
Warning
THIS SHOULD NOT BE MERGED UNTIL the Charm team has fully released all of the associated charm libraries.
This PR is currently tagged as
github.com/lrstanley/bubblezone/v2@v2.0.0-alpha.3. Use with:You can find the API for v2 here: https://pkg.go.dev/github.com/lrstanley/bubblezone/v2@v2.0.0-alpha.3
🚀 Changes proposed by this PR
charm.land/bubbletea/v2charm.land/lipgloss/v2charm.land/bubbles/v2TODO
compatfor v2, and switch examples away from adaptive.tea.Modelandtea.ViewModel-- everything I have now is just temporary for now I think.github.com/muesli/ansiv2of this library.v2of this library.🔗 Related bug reports/feature requests
🧰 Type of change
🤝 Requirements