Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

characteristic 'Temperature Display Units': characteristic value expected valid finite number and received "undefined" (undefined) #728

Open
valentinkrynin opened this issue Sep 15, 2021 · 0 comments

Comments

@valentinkrynin
Copy link

valentinkrynin commented Sep 15, 2021

Plugin version 3.6.22

Using callback just with one argument "temperatureDisplayUnits" causes warning.
I'm not sure about my proposal but maybe it's correct to use callback(null, temperatureDisplayUnits) in aircon.js file

callback(temperatureDisplayUnits);

Warning logs:
[9/15/2021, 3:23:03 PM] [homebridge-broadlink-rm] This plugin generated a warning from the characteristic 'Temperature Display Units': characteristic value expected valid finite number and received "undefined" (undefined).
[9/15/2021, 3:23:03 PM] [homebridge-broadlink-rm] Error
at TemperatureDisplayUnits.Characteristic.characteristicWarning (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:1242:41)
at TemperatureDisplayUnits.Characteristic.validateUserInput (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:1145:26)
at /usr/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:758:55
at /usr/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/util/once.js:18:25
at AirConAccessory.getTemperatureDisplayUnits (/usr/lib/node_modules/homebridge-broadlink-rm/accessories/aircon.js:563:5)

After update to callback(null, temperatureDisplayUnits); no more warnings from plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant