sqlite: enable defensive mode by default

Author: louwers

src/node_sqlite.h

@@ -79,7 +79,7 @@ class DatabaseOpenConfiguration {
   bool return_arrays_ = false;
   bool allow_bare_named_params_ = true;
   bool allow_unknown_named_params_ = false;
-  bool defensive_ = false;
+  bool defensive_ = true;
 };
 
 class DatabaseSync;

test/parallel/test-sqlite-config.js

@@ -20,30 +20,30 @@ function checkDefensiveMode(db) {
   }
 }
 
-test('by default, defensive mode is off', (t) => {
+test('by default, defensive mode is on', (t) => {
   const db = new DatabaseSync(':memory:');
-  t.assert.strictEqual(checkDefensiveMode(db), false);
+  t.assert.strictEqual(checkDefensiveMode(db), true);
 });
 
-test('when passing { defensive: true } as config, defensive mode is on', (t) => {
+test('when passing { defensive: false } as config, defensive mode is off', (t) => {
   const db = new DatabaseSync(':memory:', {
-    defensive: true
+    defensive: false
   });
-  t.assert.strictEqual(checkDefensiveMode(db), true);
+  t.assert.strictEqual(checkDefensiveMode(db), false);
 });
 
-test('defensive mode on after calling db.enableDefensive(true)', (t) => {
+test('defensive mode should be off after calling db.enableDefensive(false)', (t) => {
   const db = new DatabaseSync(':memory:');
-  db.enableDefensive(true);
-  t.assert.strictEqual(checkDefensiveMode(db), true);
+  db.enableDefensive(false);
+  t.assert.strictEqual(checkDefensiveMode(db), false);
 });
 
-test('defensive mode should be off after calling db.enableDefensive(false)', (t) => {
+test('defensive mode should be on after calling db.enableDefensive(true)', (t) => {
   const db = new DatabaseSync(':memory:', {
-    defensive: true
+    defensive: false
   });
-  db.enableDefensive(false);
-  t.assert.strictEqual(checkDefensiveMode(db), false);
+  db.enableDefensive(true);
+  t.assert.strictEqual(checkDefensiveMode(db), true);
 });
 
 test('throws if options.defensive is provided but is not a boolean', (t) => {