Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: incorrect PingChart display during Daylight Saving Time transition #843

Open
2 tasks done
luckyluc74 opened this issue Oct 31, 2021 · 4 comments
Open
2 tasks done
Labels
area:dashboard The main dashboard page where monitors' status are shown bug Something isn't working priority:low Low Priority

Comments

@luckyluc74
Copy link

luckyluc74 commented Oct 31, 2021

👟 Reproduction steps

Just let uptime-kuma run from summertime to wintertime ( FYI my time zone is Central European Time (CET) )

👍 Expected behavior

correct display of responsetime metrics

👎 Actual Behavior

responsetime metrics are overlapping

🐻 Uptime-Kuma version

1.10.0

💻 Operating System

Ubuntu 20.04.3 LTS (GNU/Linux 5.4.143-1-pve x86_64)

🌐 Browser

Waterfox Classic

🐋 Docker

20.10.10

🏷️ Docker Image Tag

louislam/uptime-kuma latest 00738a940895

🟩 NodeJS Version

No response

📝 Relevant log output

No response

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

@luckyluc74 luckyluc74 added the bug Something isn't working label Oct 31, 2021
@luckyluc74
Copy link
Author

2021-10-31 08_12_27-Uptime Kuma - Waterfox Classic
2021-10-31 08_11_57-Uptime Kuma - Waterfox Classic

Sometimes a picture is worth more than 1000 words :)

@louislam
Copy link
Owner

louislam commented Oct 31, 2021

Duplicate of #285

@louislam louislam marked this as a duplicate of #285 Oct 31, 2021
@chakflying
Copy link
Collaborator

Thanks for an actual repo of the issue! Now I know why it happens.

Unfortunately it may not be an easy fix, as I found out day.js doesn't seem to handle daylight saving transitions correctly. I guess I can switch to another date handling library just for the chart.

@louislam louislam reopened this Oct 31, 2021
@luckyluc74
Copy link
Author

luckyluc74 commented Oct 31, 2021

You are welcome. It only occurs during daylight savings transitions, so that means only twice a years. Personally I can live with this bug, but just to make aware that this bug occurs. I can image that development effort can be better spend on more critical issues :)

@CommanderStorm CommanderStorm added priority:low Low Priority area:dashboard The main dashboard page where monitors' status are shown labels Dec 5, 2023
@chakflying chakflying changed the title [Bug]: incorrect display responsetime metrics from summertime to wintertime [Bug]: incorrect PingChart display during Daylight Saving Time transition Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown bug Something isn't working priority:low Low Priority
Projects
None yet
Development

No branches or pull requests

4 participants