Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps shown in heartbeat graph for ping less than 1ms #3966

Closed
2 tasks done
supermarkert opened this issue Oct 30, 2023 · 2 comments · Fixed by #3987
Closed
2 tasks done

Gaps shown in heartbeat graph for ping less than 1ms #3966

supermarkert opened this issue Oct 30, 2023 · 2 comments · Fixed by #3987
Labels
bug Something isn't working

Comments

@supermarkert
Copy link

supermarkert commented Oct 30, 2023

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

When using a Push Monitor on my LAN and using the optional Ping paramenter, my pings are often (but not always) less than 1ms. So this results in a Push URL such as:
http://uptimekuma.lan:3001/api/push/[code]?status=up&msg=OK&ping=0.982

Which works great (I can confirm UptimeKuma has received the Push), except the Heartbeat graph on the Y-axis only seems to go down to 1.0 ms, and all pings less than 1ms are not indicated and show up as blank on the X-axis.

Node ping

👟 Reproduction steps

Create a Push monitor, and send the URL with an optional Ping parameter of < 1.0

👀 Expected behavior

I would expect the heartbeat graph to resolve all the way down to zero, and include all pings. I would be fine if the ping on the graph would simply round up to 1ms.

😓 Actual Behavior

If I hover over the ping location, I can see on the graph that the hearbeat is registered and rounded up to 1ms (this is fine), but otherwise pings < 1ms do not appear and show up as gaps in the graph, and Y-axis of the graph only goes down to 1.0 ms.

🐻 Uptime-Kuma Version

1.23.3

💻 Operating System and Arch

Debian 12 x64

🌐 Browser

Google Chrome 118.0.5993.117

🐋 Docker Version

No response

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@supermarkert supermarkert added the bug Something isn't working label Oct 30, 2023
@chakflying
Copy link
Collaborator

Fixed by #3987.

@supermarkert
Copy link
Author

Works perfect. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants